Skip to content

chore: minor update to manifest sanity check error message #1278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dentiny
Copy link
Contributor

@dentiny dentiny commented May 1, 2025

What changes are included in this PR?

This is the error message I get on my end:

Error: DataInvalid => Content type of entry PositionDeletes should have DataContentType::Data

At first sight, I have no idea what this means, until I read the sanity check code.

In this PR, I updated the error message for manifest write sanity check to provide more context:

  • What's the manifest content file
  • What's the filepath, this is useful for devs to directly understand what's the data file having issues
  • What's the expected and actual data content type

Are these changes tested?

No-op change

Copy link
Contributor

@jonathanc-n jonathanc-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @dentiny, this looks good to me!

Copy link
Contributor

@sdd sdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this @dentiny

@dentiny
Copy link
Contributor Author

dentiny commented May 12, 2025

LGTM, thanks for this @dentiny

Thank you for the code review @sdd ! Could you please help merge when you have some time? Thank you!

@sdd sdd merged commit 7bf0884 into apache:main May 12, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants