Expose UncPath for backward compatibility

[Croway]

The previous smb implementation was providing more information wrt the absolute path, for example, if camel-smb is connected to a share localhost/data-rw, and files are created under data-rw, a Camel consumer absolute path would be /fileName without data-rw, and there is no way to retrieve that information from the GenericFile, the previous implementation was handing smbj.File and that information was there.

Does it make sense to add a header with that information?

[github-actions]

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

• First-time contributors require MANUAL approval for the GitHub Actions to run

• You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

• You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

• Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

• ⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

[davsclaus]

Can you do this in all the retrieveFile methods to set that header

[orpiske]

Thanks!!!

[davsclaus]

[ERROR] org.apache.camel.component.smb.SmbComponentIT.testSmbRead -- Time elapsed: 2.028 s <<< FAILURE!
java.lang.AssertionError: mock://result Expected 1 headers with key[CamelSmbUncPath], received 0 headers. Expected header values: [\localhost\data-rw\1.txt]
at org.apache.camel.component.mock.MockEndpoint.fail(MockEndpoint.java:2015)
at org.apache.camel.component.mock.MockEndpoint.assertTrue(MockEndpoint.java:1986)
at org.apache.camel.component.mock.MockEndpoint.lambda$expectedHeaderValuesReceivedInAnyOrder$0(MockEndpoint.java:691)
at org.apache.camel.component.mock.MockEndpoint.runTests(MockEndpoint.java:488)
at org.apache.camel.component.mock.MockEndpoint.doAssertIsSatisfied(MockEndpoint.java:469)
at org.apache.camel.component.mock.MockEndpoint.assertIsSatisfied(MockEndpoint.java:431)
at org.apache.camel.component.mock.MockEndpoint.assertIsSatisfied(MockEndpoint.java:421)
at org.apache.camel.component.smb.SmbComponentIT.testSmbRead(SmbComponentIT.java:53)
at java.base/java.lang.reflect.Method.invoke(Method.java:569)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

[Croway]

[ERROR] org.apache.camel.component.smb.SmbComponentIT.testSmbRead -- Time elapsed: 2.028 s <<< FAILURE! java.lang.AssertionError: mock://result Expected 1 headers with key[CamelSmbUncPath], received 0 headers. Expected header values: [\localhost\data-rw\1.txt] at org.apache.camel.component.mock.MockEndpoint.fail(MockEndpoint.java:2015) at org.apache.camel.component.mock.MockEndpoint.assertTrue(MockEndpoint.java:1986) at org.apache.camel.component.mock.MockEndpoint.lambda$expectedHeaderValuesReceivedInAnyOrder$0(MockEndpoint.java:691) at org.apache.camel.component.mock.MockEndpoint.runTests(MockEndpoint.java:488) at org.apache.camel.component.mock.MockEndpoint.doAssertIsSatisfied(MockEndpoint.java:469) at org.apache.camel.component.mock.MockEndpoint.assertIsSatisfied(MockEndpoint.java:431) at org.apache.camel.component.mock.MockEndpoint.assertIsSatisfied(MockEndpoint.java:421) at org.apache.camel.component.smb.SmbComponentIT.testSmbRead(SmbComponentIT.java:53) at java.base/java.lang.reflect.Method.invoke(Method.java:569) at java.base/java.util.ArrayList.forEach(ArrayList.java:1511) at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

yeah, that is strange, locally is working, this line of code https://github.com/apache/camel/pull/17862/files#diff-c8ac41955f06eb913c93ab390020b89defda37d45def4e970d1fd9aeae4601d4R244 is supposed to add that header

[davsclaus]

yeah its strange

[davsclaus]

Maybe you can add some logging in that code to see what the CI server logs - its hard to reproduce this if it works locally but fails on ASF CI only.

[davsclaus]

okay I have a fix in the works

[davsclaus]

okay fixed and merged in another commit

[Croway]

okay fixed and merged in another commit

Thanks a lot Claus.