-
Notifications
You must be signed in to change notification settings - Fork 132
feat: add artifact upload steps for JSONL logs in local and remote test workflows #3905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Reviewer's GuideThis pull request modifies the GitHub Actions workflows ( File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @germa89 - I've reviewed your changes - here's some feedback:
- Consider if the
.jsonl
files should still be part of thelogs-*.tgz
archive, given they are now separate artifacts intended to help avoid downloading large files.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3905 +/- ##
==========================================
+ Coverage 88.32% 88.34% +0.01%
==========================================
Files 187 187
Lines 14830 14830
==========================================
+ Hits 13099 13101 +2
+ Misses 1731 1729 -2 🚀 New features to boost your workflow:
|
@pyansys-ci-bot LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
Upload the report logs to independent artifacts so we don't have to download huge files. Keeping the report files in the zip too.
Issue linked
NA
Checklist
draft
if it is not ready to be reviewed yet.feat: adding new MAPDL command
)Summary by Sourcery
Enhance GitHub Actions workflows to upload JSONL log files as separate artifacts for both local and remote test workflows
Enhancements:
CI: