Skip to content

ci: use own DPF standalone Docker image reference in workflows #3882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
May 14, 2025

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Apr 30, 2025

Description

As the title.

Issue linked

Related #3852

Checklist

@germa89 germa89 requested a review from a team as a code owner April 30, 2025 18:03
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Apr 30, 2025
@germa89
Copy link
Collaborator Author

germa89 commented Apr 30, 2025

@pyansys-ci-bot LGTM.

@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc maintenance General maintenance of the repo (libraries, cicd, etc) labels Apr 30, 2025
Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89
Copy link
Collaborator Author

germa89 commented May 5, 2025

Failing at the moment. Waiting for ansys/pydpf-core#2254

Copy link

codecov bot commented May 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.28%. Comparing base (fb448fb) to head (2ce1b91).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3882   +/-   ##
=======================================
  Coverage   88.27%   88.28%           
=======================================
  Files         187      187           
  Lines       14830    14830           
=======================================
+ Hits        13091    13092    +1     
+ Misses       1739     1738    -1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@germa89 germa89 force-pushed the ci/usind-dpf-standalone-in-cicd branch from 6b6b2bc to 1b3229b Compare May 13, 2025 15:20
@germa89
Copy link
Collaborator Author

germa89 commented May 13, 2025

I had to change the docker image from ubuntu to rocky OS. For some reason, the ubuntu version does not work.

@germa89
Copy link
Collaborator Author

germa89 commented May 14, 2025

Remote: v25.1-ubuntu-student / test-remote is failing and I dont know why.

The other setups (remote v24.2 and v25.2/latest) are working fine.

@germa89
Copy link
Collaborator Author

germa89 commented May 14, 2025

Remote: v25.1-ubuntu-student / test-remote is failing and I dont know why.

The other setups (remote v24.2 and v25.2/latest) are working fine.

My fault, I did overwrite the DPF image with the daily built. That is why I had to specify Rocky version of the standalone docker image.

@germa89 germa89 merged commit 3e7f524 into main May 14, 2025
50 checks passed
@germa89 germa89 deleted the ci/usind-dpf-standalone-in-cicd branch May 14, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Related with CICD, Github Actions, etc dependencies maintenance General maintenance of the repo (libraries, cicd, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants