Update networking jumphost examples #2586
Merged
+52
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ansible.networking.network_cli connection plugin uses the ansible.netcommon.libssh connection plugin or falls back to ansible.builtin.paramiko. The ansible.builtin.paramiko connection no longer uses the variable 'ansible_ssh_common_args' to configure connecting via a jumphost, and now requires the variable 'ansible_paramiko_proxy_command'. This variable is also supported by ansible.netcommon.libssh >= 2.2.0 (in addition to ansible_libssh_proxy_command). Also fix example for ansible.netcommon.netconf, which never appears to have never supported 'ansible_ssh_common_args', but does support 'ansible_paramiko_proxy_command' and 'ansible_netconf_proxy_command'.
samccann
approved these changes
May 6, 2025
samccann
added
backport-2.18
Backport to stable-2.18: 💚 backport PR created✅ Backport PR branch: Backported as #2594 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
May 6, 2025
…2586) The ansible.networking.network_cli connection plugin uses the ansible.netcommon.libssh connection plugin or falls back to ansible.builtin.paramiko. The ansible.builtin.paramiko connection no longer uses the variable 'ansible_ssh_common_args' to configure connecting via a jumphost, and now requires the variable 'ansible_paramiko_proxy_command'. This variable is also supported by ansible.netcommon.libssh >= 2.2.0 (in addition to ansible_libssh_proxy_command). Also fix example for ansible.netcommon.netconf, which never appears to have never supported 'ansible_ssh_common_args', but does support 'ansible_paramiko_proxy_command' and 'ansible_netconf_proxy_command'. (cherry picked from commit 3464ee2)
Backport to stable-2.19: 💚 backport PR created✅ Backport PR branch: Backported as #2595 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
May 6, 2025
…2586) The ansible.networking.network_cli connection plugin uses the ansible.netcommon.libssh connection plugin or falls back to ansible.builtin.paramiko. The ansible.builtin.paramiko connection no longer uses the variable 'ansible_ssh_common_args' to configure connecting via a jumphost, and now requires the variable 'ansible_paramiko_proxy_command'. This variable is also supported by ansible.netcommon.libssh >= 2.2.0 (in addition to ansible_libssh_proxy_command). Also fix example for ansible.netcommon.netconf, which never appears to have never supported 'ansible_ssh_common_args', but does support 'ansible_paramiko_proxy_command' and 'ansible_netconf_proxy_command'. (cherry picked from commit 3464ee2)
samccann
pushed a commit
that referenced
this pull request
May 6, 2025
…2586) (#2594) The ansible.networking.network_cli connection plugin uses the ansible.netcommon.libssh connection plugin or falls back to ansible.builtin.paramiko. The ansible.builtin.paramiko connection no longer uses the variable 'ansible_ssh_common_args' to configure connecting via a jumphost, and now requires the variable 'ansible_paramiko_proxy_command'. This variable is also supported by ansible.netcommon.libssh >= 2.2.0 (in addition to ansible_libssh_proxy_command). Also fix example for ansible.netcommon.netconf, which never appears to have never supported 'ansible_ssh_common_args', but does support 'ansible_paramiko_proxy_command' and 'ansible_netconf_proxy_command'. (cherry picked from commit 3464ee2) Co-authored-by: Sloane Hertel <19572925+s-hertel@users.noreply.github.com>
samccann
pushed a commit
that referenced
this pull request
May 6, 2025
…2586) (#2595) The ansible.networking.network_cli connection plugin uses the ansible.netcommon.libssh connection plugin or falls back to ansible.builtin.paramiko. The ansible.builtin.paramiko connection no longer uses the variable 'ansible_ssh_common_args' to configure connecting via a jumphost, and now requires the variable 'ansible_paramiko_proxy_command'. This variable is also supported by ansible.netcommon.libssh >= 2.2.0 (in addition to ansible_libssh_proxy_command). Also fix example for ansible.netcommon.netconf, which never appears to have never supported 'ansible_ssh_common_args', but does support 'ansible_paramiko_proxy_command' and 'ansible_netconf_proxy_command'. (cherry picked from commit 3464ee2) Co-authored-by: Sloane Hertel <19572925+s-hertel@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ansible.netcommon.network_cliconnection plugin uses theansible.netcommon.libsshconnection plugin or falls back toansible.builtin.paramiko.In ansible-core 2.18, the
ansible.builtin.paramikoconnection no longer uses the variableansible_ssh_common_argsto configure a jumphost, and instead requires the variableansible_paramiko_proxy_command(which is compatible withansible.netcommon.libsshin ansible.netcommon >= 2.2.0 too).Using the wrong variable could cause issues like https://forum.ansible.com/t/while-running-playbook-ansible-is-not-using-the-proxy/42323.
I also fixed the example for
ansible.netcommon.netconf, which never appears to have never supportedansible_ssh_common_args, but does supportansible_paramiko_proxy_commandandansible_netconf_proxy_commandto configure a jumphost.