Fix Unpin rstcheck #2383
Open
Fix Unpin rstcheck #2383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganeshhubale
temporarily deployed
to
github-bot
GitHub Actions
Inactive
Signed-off-by: Ganesh Hubale <ganeshhubale03@gmail.com>
ganeshhubale
force-pushed
the
issue-rstcheck-1710
branch
from
66e631b to
86b8efc
Compare
ganeshhubale
temporarily deployed
to
github-bot
GitHub Actions
Inactive
|
@oraNod Since I'm not actively involved in the docs repo maintenance, I'll leave the review to those who are. |
fair enough! I thought it might be appropriate to highlight. thanks for letting us know. |
| ) | ||
|
|
||
| # Run the checks | ||
| exit_code = runner.run() |
There was a problem hiding this comment.
One problem with runner.run() is that it prints messages in a slightly different format. First, it prints a general success/failure message that's not of the expected format. Then, it uses the format FILE:LINE: MSG instead of FILE:LINE:COL: MSG.
It might be better to simply run runner.check() and handle what runner.print_result() does here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #1710
Discussion for reference - #2344