APS Updates #89
APS Updates #89
Conversation
This reverts commit 9837574.
# Conflicts: # com.adsbynimbus.nimbus/Runtime/Plugins/iOS/NimbusManager.swift # com.adsbynimbus.nimbus/Runtime/Scripts/Nimbus.Internal/LiveRamp/NimbusLiveRampHelpers.cs
There was a problem hiding this comment.
At the moment Android does not have the ability to differentiate between Interstiital Video and Rewarded Video using the addApsSlot method so until those changes can be made in the SDK or the code to retrieve the APS params is moved into this project and updated correctly, we should hold off on merging this in.
| found = true; | ||
| break; | ||
| var interstitialVideo = false; | ||
| foreach (ApsSlotData slot in _slotData){ |
There was a problem hiding this comment.
The previous for loop implementation for matching slots was fine since it was only checking a single condition but as the complexity has grown, this pattern becomes much harder to maintain as it is currently lacking adequate testing and will be prone to future error.
Is it possible to replace this with the .Net Find function?
| found = true; | ||
| break; | ||
| var interstitialVideo = false; | ||
| foreach (ApsSlotData slot in _slotData){ |
There was a problem hiding this comment.
This looks to be duplicated from the Android code, is it possible to use a single method for retrieving the slot that can be used by both platforms?
| @@ -46,39 +47,77 @@ public void InitializeNativeSDK() { | |||
| adRegistration.CallStatic("enableTesting", true); | |||
| } | |||
|
|
|||
| private static Tuple<int, int> AdTypeToDim(AdUnitType type) { | |||
| private static Tuple<int, int> AdTypeToDim(APSAdUnitType type) { | |||
There was a problem hiding this comment.
If you were to store the width and height of the ad on the ApsAdSlot you could remove this function and reference those values directly.
Changed APS Ad Unit Types and updated code to mirror the APS portal.