-
Notifications
You must be signed in to change notification settings - Fork 1.2k
chore: update to node 22 #8101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update to node 22 #8101
Conversation
@snowystinger Btw, shouldn't the |
@nwidynski doesn't look like it
vs
It doesn't actually seem to specify either syntax here https://github.com/nvm-sh/nvm?tab=readme-ov-file#nvmrc Here's what their
Are you running into an issue using the current entry? or where are you coming up with the |
@snowystinger Meh, apparently both are valid, but even Im currently experiencing trouble with |
It looks like we don't actually need star syntax, we could just use the number |
@snowystinger Yes 👍 |
Closes
You might notice that @react-aria/ssr still declares
We can't update this without it no longer handling optional chaining, which webpack 4 cannot handle. So it remains at 12 for everyone and our code transpiles larger. 🤷🏻♂️
There is also now a deprecation warning for
punycode
, this will eventually go away most likely when storybook upgrade is complete and whenever we finally axe lerna.✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: