Switch branch Action

[aarnapant-sap]

Switch Branch Functionality in AbapGit

• User can now switch branch for the linked repository without explicitly unlinking and relinking.
• SwitchBranchAction is added to context menu in AbapGitRepository view.
• added pde tests for switchBranchWizard

[shubhamWaghmare-sap]

Remove the backlog link from the description. Instead add some description of what the pull request solves.

• backlog link click here support for branch switching for a linked repository

[shubhamWaghmare-sap]

@aarnapant-sap Please also test the solution in a ABAP Cloud system, involving transport requests.

[shubhamWaghmare-sap]

Hi Aarnav,
Overall looks good.
I have added some comments and questions. Please check them.

[shubhamWaghmare-sap]

• More test cases can be covered like invalid package or exception while fetching repo type.
• Also a UI test can be added to open the wizard, validate the fields in first page, then navigate to next page and validate if the branches are correctly set as input for combo viewer, and switch the branch in combo viewer. The Finish action can be skipped.

[shubhamWaghmare-sap]

Instead of taking any parameters, the message can be directly set here itself.

[shubhamWaghmare-sap]

Suggested change

	if (getPackageAndRepoType(destination)) {
	WizardDialog dialog = new WizardDialog(this.AbapGitView.getViewSite().getShell(),
	new AbapGitWizardSwitchBranch(this.project, this.selRepo, destination));
	dialog.open();
	}
	try {
	WizardDialog dialog = new WizardDialog(this.AbapGitView.getViewSite().getShell(),
	new AbapGitWizardSwitchBranch(this.project, this.selRepo, destination));
	dialog.open();
	} catch (PackageRefNotFoundException | ResourceException e) {
	MessageDialog.openError(this.AbapGitView.getViewSite().getShell(), "Switch Branch Wizard Error",
	e.getLocalizedMessage());
	}

• The idea is that the repo type and package info is retrieved while creating the object of the wizard
• This wizard also sends the new exception for package ref not found
• Also, the post call to backend can possibly throw a ResourceException, in case there is an issue in backend. This can be explicitly handled here.
• The shell to we can get from the abapgit view

[shubhamWaghmare-sap]

This could be considered redundant as the creation of the wizard already gets the required info and performs the required checks about the package and repository type.
We can remove this logic.

[shubhamWaghmare-sap]

• From here itself we can throw the exception if package does not exist
• Also the progress monitor is not needed much here as the wizard is not yet started. So we can pass a null progress monitor

[shubhamWaghmare-sap]

Suggested change

	private void getPackageRef(String packageName, IProgressMonitor monitor) {
	IAdtPackageServiceUI packageServiceUI = AdtPackageServiceUIFactory.getOrCreateAdtPackageServiceUI();
	if (packageServiceUI.packageExists(AbapGitWizardSwitchBranch.this.destination, packageName, monitor)) {
	List<IAdtObjectReference> packageRefs = packageServiceUI.find(AbapGitWizardSwitchBranch.this.destination, packageName, monitor);
	AbapGitWizardSwitchBranch.this.cloneData.packageRef = packageRefs.stream().findFirst().orElse(null);
	}
	}
	private void getPackageRef(String packageName) throws PackageRefNotFoundException {
	IAdtPackageServiceUI packageServiceUI = AdtPackageServiceUIFactory.getOrCreateAdtPackageServiceUI();
	if (packageServiceUI.packageExists(AbapGitWizardSwitchBranch.this.destination, packageName, new NullProgressMonitor())) {
	List<IAdtObjectReference> packageRefs = packageServiceUI.find(AbapGitWizardSwitchBranch.this.destination, packageName,
	new NullProgressMonitor());
	AbapGitWizardSwitchBranch.this.cloneData.packageRef = packageRefs.stream().findFirst().orElse(null);
	}
	else {
	throw new PackageRefNotFoundException("Package not found"); //$NON-NLS-1$
	}
	}

[shubhamWaghmare-sap]

The idea is to not handle any exception here.
All exceptions should be handled by the caller.

[shubhamWaghmare-sap]

Suggested change

	public boolean getPackageAndRepoType() {
	try {
	String packageName = AbapGitWizardSwitchBranch.this.selRepoData.getPackage();
	PlatformUI.getWorkbench().getProgressService().run(true, true, new IRunnableWithProgress() {
	@Override
	public void run(IProgressMonitor monitor) throws InvocationTargetException, InterruptedException {
	monitor.beginTask(Messages.AbapGitWizardPageBranchAndPackage_task_package_validation_message, IProgressMonitor.UNKNOWN);
	// fetches wether the repository is PUBLIC or PRIVATE from external repo info
	getRepositoryAccessMode();
	// fetches associated package
	getPackageRef(packageName, monitor);
	}
	});
	// returns false in case of missing package reference
	return this.cloneData.packageRef != null;
	} catch (InterruptedException | InvocationTargetException e) {
	Shell shell = PlatformUI.getWorkbench().getActiveWorkbenchWindow().getShell();
	MessageDialog.openError(shell, "Error", e.getMessage()); //$NON-NLS-1$
	return false;
	}
	}
	public void getPackageAndRepoType() throws PackageRefNotFoundException {
	String packageName = AbapGitWizardSwitchBranch.this.selRepoData.getPackage();
	// fetches wether the repository is PUBLIC or PRIVATE from external repo info
	getRepositoryAccessMode();
	// fetches associated package
	getPackageRef(packageName);
	}

[shubhamWaghmare-sap]

We will add a throws declaration to the constructor for PackageRefNotFoundException.