Skip to content

Improve License file. #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Improve License file. #40

wants to merge 4 commits into from

Conversation

polarisfm
Copy link

Remove the somewhat rambly LICENSE.txt in favor of a LICENSE file that simply contains the same modified BSD 3-clause license and more up-to-date copyright attribution.

@GXTX
Copy link
Contributor

GXTX commented Jul 2, 2020

I have no thoughts on this but since you are changing something that gets included in the CI stuff can you also change it in .github/workflows/CI.yml, should be 3 lines to change. Would probably also be a good idea to change it in extract-xiso.c as well where it's much more rambly and includes a weird changelog.

LICENSE.TXT -> LICENSE

@JayFoxRox
Copy link
Member

nit: Please remove trailing period from the commit messages for consistency with our git log.

Ideally squash commits and just call it something like "Cleanup license file"

@polarisfm polarisfm closed this Jul 2, 2020
@JayFoxRox
Copy link
Member

Replaced by #41 (Reason: user is inexperienced with GitHub and probably didn't know that you can force-push to existing PRs; maybe also accidentally deleted their repository or branch).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants