Fix InterpolationTokenRenderer appending value without culture formatting #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting The value is only formatted for the correct culture if the token requests that the value is escaped (i.e. `obj.EscapeResult`). Otherwise it just calls `StringBuilder.Append()` with the raw value, which does not use the configured culture of our `CompilationSettings`. ## Benchmarks I did not notice any meaningful difference in benchmarks. I included Nustache as a baseline. | Method | Index | Mean | Error | StdDev | Renderer | Gen 0 | Gen 1 | Allocated | |------------------- |------ |------------:|----------:|----------:|--------- |-------:|-------:|----------:| | Stubble_Before | 1 | 743.0 ns | 10.94 ns | 9.70 ns | Stubble | 0.4292 | 0.0038 | 3 KB | | Nustache_Before | 1 | 12,082.0 ns | 231.74 ns | 317.21 ns | Nustache | 3.6774 | 0.0916 | 23 KB | | Stubble_After | 1 | 725.8 ns | 11.44 ns | 10.70 ns | Stubble | 0.4292 | 0.0038 | 3 KB | | Nustache_After | 1 | 11,601.8 ns | 122.77 ns | 108.83 ns | Nustache | 3.6774 | 0.0916 | 23 KB | ## Background I noticed this issue because these two interpolation tests failed on my PC: - `Triple Mustache Decimal Interpolation` - `Ampersand Decimal Interpolation` ``` Expected: "1.21 jiggawatts!" Actual: "1,21 jiggawatts!" ``` My PC has Swedish formatting settings and thus uses `,` instead of `.` as a decimal separator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value is only formatted for the correct culture if the token requests that the value is escaped (i.e.
obj.EscapeResult). Otherwise it just callsStringBuilder.Append()with the raw value, which does not use the configured culture of ourCompilationSettings.Benchmarks
I did not notice any meaningful difference in benchmarks. I included Nustache as a baseline.
Background
I noticed this issue because these two interpolation tests failed on my PC:
Triple Mustache Decimal InterpolationAmpersand Decimal InterpolationMy PC has Swedish formatting settings and thus uses
,instead of.as a decimal separator.