[Enhancement] Enable low cardinality optimization on PRIMARY KEY tables. #59487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jinho Kim <117620956+jkim650@users.noreply.github.com>
Signed-off-by: Jinho Kim <117620956+jkim650@users.noreply.github.com>
Signed-off-by: Jinho Kim <117620956+jkim650@users.noreply.github.com>
|
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
chaoyli
approved these changes
Jun 3, 2025
stdpain
approved these changes
Jun 3, 2025
Seaven
approved these changes
Jun 5, 2025
|
@Mergifyio backport branch-3.4 |
|
@Mergifyio backport branch-3.5 |
|
@Mergifyio backport branch-3.3 |
✅ Backports have been created
|
✅ Backports have been created
|
✅ Backports have been created
|
Closed
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
To enable low cardinality optimization on PRIMARY KEY tables.
What I'm doing:
Removes a check restricting the optimization on PRIMARY KEY tables.
The optimization works only when global dictionaries are available. If there is a global dictionary, we don't need to restrict the optimization.
I tested this by changing tables in the unittests(LowCardinalityArrayTest.java and LowCardinalityTest2.java) to PRIMARY KEY tables and confirmed it worked. In the PR, I left 2 of those table changes in unittests.
I also tested this in internal e2e tests of our company.
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: