-
Notifications
You must be signed in to change notification settings - Fork 7
Update index.md #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update index.md #85
Conversation
@Rubix982 Kindly approve my changes. Thanks! Note: I have provided main branch links so that in future, if I update any material, it will reflect here too. So, don't change them plz!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes requested as per comments.
learning-resources/misc/index.md
Outdated
@@ -66,6 +66,10 @@ What other resources can you find? Try out, | |||
- [Muhammad Kamran Qadri](https://web.facebook.com/groups/softdevpk/permalink/966099857180373/) | |||
- [Muhammad Kamran Qadri](https://web.facebook.com/groups/softdevpk/permalink/966755790448113/) | |||
|
|||
3. [**Click here**](https://github.com/HypertextAssassin0273/Data_Structures_in_Cpp) to get custom & easy implementation of some **STL containers**, alongwith complete **FAST_Course_Spring_21** material (provided by [Shahzaib Khan](https://hypertextassassin0273.github.io/)). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it's a repository, it would be a great idea if we could make a section for Repository
entirely.
So this can be a pretty concise description as well, such as,
## Repository
- [Custom C++ STL Containers Implementation](https://github.com/HypertextAssassin0273/Data_Structures_in_Cpp)
A direct link to "FAST_Course_Spring_21" can be provided - "provided by Shahzaib Khan" is redundant is it leads to the GitHub page anyways.
learning-resources/misc/index.md
Outdated
4. [**Here**](https://hypertextassassin0273.github.io/blog-posts/) are some very interesting & useful articles on Data-Structures in Cpp (contributed by [Shahzaib Khan](https://hypertextassassin0273.github.io/)). | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same review as above. Can be more concise and separated.
Hi, @HypertextAssassin0273 ! Thank you for your contribution. I left a review, check it out? PS: The PR title and the commit can be improved. Check out Conventional Commits for a standard if it helps - it doesn't always fit everywhere, but it can be a nice start. Just keep in mind being concise and easy to read for others. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! This looks fantastic.
@Rubix982 Kindly approve my changes. Thanks!
Note: I have provided main branch links so that in future, if I update any material, it will reflect here too. So, don't change them plz!
Type of changes in PR:
📜 Documentation