Skip to content

fix(ui5-side-navigation): right arrow and left arrow behavior fixed #11434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(ui5-side-navigation): right arrow and left arrow behavior fixed #11434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5b909d1
fix(ui-side-navigation): right arrow and left arrow behavior fixed
Apr 29, 2025
74681ac
fix: correct expand/collapse behavior for groups
May 12, 2025
e671f04
fix: edit tests
May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
278 changes: 278 additions & 0 deletions packages/fiori/cypress/specs/SideNavigation.cy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,284 @@ describe("Side Navigation interaction", () => {
cy.get("#unselectableItem").should("be.focused").and("not.have.attr", "expanded");
});

it("Tests expanding of items with ArrowRight", () => {
cy.mount(
<SideNavigation id="sn">
<SideNavigationItem id="focusStart" text="focus start"></SideNavigationItem>
<SideNavigationItem id="unselectableItem" text="1">
<SideNavigationSubItem text="1.2" />
</SideNavigationItem>
</SideNavigation>
);

cy.get("#focusStart").realClick();
cy.realPress("ArrowDown");
cy.realPress("ArrowRight");

cy.get("#unselectableItem").should("have.attr", "expanded");
});

it("Tests collapsing of items with ArrowLeft", () => {
cy.mount(
<SideNavigation id="sn">
<SideNavigationItem id="focusStart" text="focus start"></SideNavigationItem>
<SideNavigationItem id="unselectableItem" text="1" expanded>
<SideNavigationSubItem text="1.2" />
</SideNavigationItem>
</SideNavigation>
);
cy.get("#focusStart").realClick();
cy.realPress("ArrowDown");
cy.realPress("ArrowLeft");

cy.get("#unselectableItem").should("not.have.attr", "expanded");

});

it("Tests expanding of items with ArrowRight on collapsed sn", () => {
cy.mount(
<SideNavigation id="sn" collapsed={true}>
<SideNavigationItem id="focusStart" text="focus start"></SideNavigationItem>
<SideNavigationItem id="unselectableItem" text="1">
<SideNavigationSubItem id="snn1" text="1.2" />
</SideNavigationItem>
</SideNavigation>
);

cy.get("#focusStart").should("exist");
cy.get("#focusStart").realClick();

cy.realPress("ArrowDown");
cy.realPress("ArrowRight");
cy.get("#unselectableItem").realPress("ArrowRight");

cy.get("#sn")
.shadow()
.find("[ui5-responsive-popover]")
.should("be.visible");
});

it("Tests collapsing of items with ArrowLeft on collapsed sn", () => {
cy.mount(
<SideNavigation id="sn" collapsed={true}>
<SideNavigationItem id="focusStart" text="focus start"></SideNavigationItem>
<SideNavigationItem id="unselectableItem" text="1" expanded>
<SideNavigationSubItem text="1.2" />
</SideNavigationItem>
</SideNavigation>
);

cy.get("#unselectableItem").realPress("ArrowLeft");

cy.get("#sn")
.shadow()
.find("[ui5-responsive-popover]")
.should("not.have.attr", "open");
});

it("Tests expanding of items with ArrowLeft for rtl", () => {
cy.mount(
<div dir="rtl">
<SideNavigation id="sn">
<SideNavigationItem id="focusStart" text="focus start"></SideNavigationItem>
<SideNavigationItem id="unselectableItem" text="1" expanded>
<SideNavigationSubItem text="1.2" />
</SideNavigationItem>
</SideNavigation>
</div>
);

cy.get("#focusStart").realClick();
cy.realPress("ArrowDown");
cy.realPress("ArrowLeft");

cy.get("#unselectableItem").should("have.attr", "expanded");
});

it("Tests collapsing of items with ArrowRight for rtl", () => {
cy.mount(
<div dir="rtl">
<SideNavigation id="sn">
<SideNavigationItem id="focusStart" text="focus start"></SideNavigationItem>
<SideNavigationItem id="unselectableItem" text="1" expanded>
<SideNavigationSubItem text="1.2" />
</SideNavigationItem>
</SideNavigation>
</div>
);
cy.get("#focusStart").realClick();
cy.realPress("ArrowDown");
cy.realPress("ArrowRight");

cy.get("#unselectableItem").should("not.have.attr", "expanded");

});

it("Tests expanding of items with ArrowLeft on collapsed sn for rtl", () => {
cy.mount(
<div dir="rtl">
<SideNavigation id="sn" collapsed={true}>
<SideNavigationItem id="focusStart" text="focus start"></SideNavigationItem>
<SideNavigationItem id="unselectableItem" text="1">
<SideNavigationSubItem text="1.2" />
</SideNavigationItem>
</SideNavigation>
</div>
);

cy.get("#focusStart").should("exist");
cy.get("#focusStart").realClick();

cy.realPress("ArrowDown");
cy.realPress("ArrowLeft");

cy.get("#sn")
.shadow()
.find("[ui5-responsive-popover]")
.should("be.visible");
});

it("Tests collapsing of items with ArrowRight on collapsed sn for rtl", () => {
cy.mount(
<div dir="rtl">
<SideNavigation id="sn" collapsed={true}>
<SideNavigationItem id="focusStart" text="focus start"></SideNavigationItem>
<SideNavigationItem id="unselectableItem" text="1" expanded>
<SideNavigationSubItem text="1.2" />
</SideNavigationItem>
</SideNavigation>
</div>
);

cy.get("#unselectableItem").realPress("ArrowRight");

cy.get("#sn")
.shadow()
.find("[ui5-responsive-popover]")
.should("not.have.attr", "open");
});

it("Tests expanding of items with Plus", () => {
cy.mount(
<SideNavigation id="sn">
<SideNavigationItem id="focusStart" text="focus start"></SideNavigationItem>
<SideNavigationItem id="unselectableItem" text="1">
<SideNavigationSubItem text="1.2" />
</SideNavigationItem>
</SideNavigation>
);

cy.get("#focusStart").realClick();
cy.realPress("ArrowDown");
cy.realPress("+");

cy.get("#unselectableItem").should("have.attr", "expanded");

});

it("Tests collapsing of items with Minus", () => {
cy.mount(
<SideNavigation id="sn">
<SideNavigationItem id="focusStart" text="focus start"></SideNavigationItem>
<SideNavigationItem id="unselectableItem" text="1">
<SideNavigationSubItem text="1.2" />
</SideNavigationItem>
</SideNavigation>
);
cy.realPress("-");

cy.get("#unselectableItem").should("not.have.attr", "expanded");

});

it("Tests expanding and collapsing of unselectable items with Plus and Minus", () => {
cy.mount(
<SideNavigation id="sn" collapsed={true}>
<SideNavigationItem id="focusStart" text="focus start"></SideNavigationItem>
<SideNavigationItem id="unselectableItem" text="1">
<SideNavigationSubItem text="1.2" />
</SideNavigationItem>
</SideNavigation>
);

cy.get("#unselectableItem").realClick();

cy.get("#sn")
.shadow()
.find("[ui5-responsive-popover]")
.as("popover");

cy.get("@popover").should("have.attr", "open");

cy.get("#focusStart").realClick();
cy.realPress("+");
cy.realPress("-");

cy.get("@popover").should("not.be.visible");
});

it("Tests expanding of items with Plus for rtl", () => {
cy.mount(
<div dir="rtl">
<SideNavigation id="sn">
<SideNavigationItem id="focusStart" text="focus start"></SideNavigationItem>
<SideNavigationItem id="unselectableItem" text="1">
<SideNavigationSubItem text="1.2" />
</SideNavigationItem>
</SideNavigation>
</div>
);

cy.get("#focusStart").realClick();
cy.realPress("ArrowDown");
cy.realPress("+");

cy.get("#unselectableItem").should("have.attr", "expanded");
});

it("Tests collapsing of items with Minus for rtl", () => {
cy.mount(
<div dir="rtl">
<SideNavigation id="sn">
<SideNavigationItem id="focusStart" text="focus start"></SideNavigationItem>
<SideNavigationItem id="unselectableItem" text="1" expanded>
<SideNavigationSubItem text="1.2" />
</SideNavigationItem>
</SideNavigation>
</div>
);
cy.get("#focusStart").realClick();
cy.realPress("ArrowDown");
cy.realPress("-");

cy.get("#sn")
.shadow()
.find("[ui5-responsive-popover]")
.should("not.have.attr", "expanded");

});

it("Tests collapsing and expanding of items with Minus and Plus for rtl", () => {
cy.mount(
<div dir="rtl">
<SideNavigation id="sn" collapsed={true}>
<SideNavigationItem id="focusStart" text="focus start"></SideNavigationItem>
<SideNavigationItem id="unselectableItem" text="1" expanded>
<SideNavigationSubItem text="1.2" />
</SideNavigationItem>
</SideNavigation>
</div>
);

cy.get("#unselectableItem").realPress("ArrowDown");
cy.realPress("-");

cy.get("#sn")
.shadow()
.find("[ui5-responsive-popover]")
.should("not.have.attr", "expanded");
});

it("Tests expanding and collapsing of unselectable parent item when SideNavigation is collapsed", () => {
cy.mount(
<SideNavigation id="sideNav" collapsed={true}>
Expand Down
Loading