Toolbar items physical

[PetyaMarkovaBogdanova]

Toolbar items made physical.
Fixes: #10622

[dobrinyonkov]

A few class members that are no longer used can be deleted:

Toolbar

• getRegisteredToolbarItemByID
  • and itemsDOM
• getItemByID
• hasItemWithText
  • and ToolbarItem's containsText
• itemsWidthMeasured

ToolbarItem

• containsText
• toolbarTemplate
• toolbarPopoverTemplate

PR's title needs to include the refactor semantic tag.
Also, we can describe a short summary of the changes in the PR's body.

[dobrinyonkov]

We can delete this method as it no longer provides any value, we can work with this.items directly.

[dobrinyonkov]

As this is used by the subclasses which inherit the toolbar item, this property is protected. We can also define it without the underslash.

[dobrinyonkov]

Let's refactor the classes getter to return ClassMap:

Parent

	get classes() {
		return {
		    "ui5-tb-popover-item": this._isOverflowed,
		    "ui5-tb-item": true
		};
	}

Child

	/**
	 * @override
	 */
	get classes() {
		return {
		    ...super.classes,
		    "ui5-tb-button": true
		};
	}

[dobrinyonkov]

The line display: this.hidden ? "none" : "block", must no longer be needed as the hidden attribute will affect the physical item. We also have a private property hidden #10915 (comment) that can also be removed.

[dobrinyonkov]

This is needed because we've added a little "hack" in the toolbar, overriding the _getRealDomRef of each items

ui5-webcomponents/packages/main/src/Toolbar.ts

Line 558 in 0ffbede

item._getRealDomRef = () => this.getDomRef()!.querySelector(`[data-ui5-stable*=${item.stableDomRef}]`)

If you check, even the getDomRef is not working.

Removing the hack (which is no longer needed) should fix both the getDomRef and getFocusDomRef methods, without any overrides.