[MRG] Fix None init plan in unbalanced lbfgs solvers #731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rflamary
reviewed
Apr 25, 2025
ot/unbalanced/_lbfgs.py
Outdated
| G0 = a[:, None] * b[None, :] if G0 is None else nx.to_numpy(G0) | ||
| c = a[:, None] * b[None, :] if c is None else nx.to_numpy(c) | ||
|
|
||
| # wrap the callable function to handle numpy arrays |
There was a problem hiding this comment.
maybe we create a function in utils that provide a check/wrapper around functions for numpy conversion? hat seems like something we might need?
There was a problem hiding this comment.
Done via ot.utils.fun_to_numpy. Could you please double check the implementation ?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #731 +/- ##
=======================================
Coverage 97.09% 97.10%
=======================================
Files 100 100
Lines 20432 20453 +21
=======================================
+ Hits 19839 19861 +22
+ Misses 593 592 -1 🚀 New features to boost your workflow:
|
cedricvincentcuaz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
fix undesirable behaviour of
ot.unbalanced.lbfgsb_unbalancedwhenisinstance(reg_div, tuple)to test whether included functions in reg_div can handle numpy arrays. These tests are now handled viaot.utils.fun_to_numpy.Motivation and context / Related issue
How has this been tested (if it applies)
PR checklist