-
Notifications
You must be signed in to change notification settings - Fork 52
Support remote inference on Triton Inference Server with ease of use #536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: M Q <mingmelvinq@nvidia.com>
…ded a new example Signed-off-by: M Q <mingmelvinq@nvidia.com>
…4 for no specific reasons Signed-off-by: M Q <mingmelvinq@nvidia.com>
b2301bd
to
faec441
Compare
Signed-off-by: M Q <mingmelvinq@nvidia.com>
Signed-off-by: M Q <mingmelvinq@nvidia.com>
Signed-off-by: M Q <mingmelvinq@nvidia.com>
Signed-off-by: M Q <mingmelvinq@nvidia.com>
Signed-off-by: M Q <mingmelvinq@nvidia.com>
Signed-off-by: M Q <mingmelvinq@nvidia.com>
Signed-off-by: M Q <mingmelvinq@nvidia.com>
Signed-off-by: M Q <mingmelvinq@nvidia.com>
mocsharp
reviewed
Apr 21, 2025
mocsharp
approved these changes
Apr 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you.
Signed-off-by: M Q <mingmelvinq@nvidia.com>
|
MMelQin
added a commit
that referenced
this pull request
Apr 22, 2025
…536) * Adding requirements for Triton client impl Signed-off-by: M Q <mingmelvinq@nvidia.com> * Updated/added core classes to support Triton remote inference, and added a new example Signed-off-by: M Q <mingmelvinq@nvidia.com> * GitHub build server complains about conflicts for tritonclient[]>=2.54 for no specific reasons Signed-off-by: M Q <mingmelvinq@nvidia.com> * Fix flake8 complaints Signed-off-by: M Q <mingmelvinq@nvidia.com> * Fix pytype complaints by simplifying code Signed-off-by: M Q <mingmelvinq@nvidia.com> * Remove now unused imports Signed-off-by: M Q <mingmelvinq@nvidia.com> * Addressed all pytype and mypy complaint in new code in the dev env Signed-off-by: M Q <mingmelvinq@nvidia.com> * No complaint in local dev env, but on GitHub Signed-off-by: M Q <mingmelvinq@nvidia.com> * Add model confgi.pbtxt and example env settings Signed-off-by: M Q <mingmelvinq@nvidia.com> * Doc update Signed-off-by: M Q <mingmelvinq@nvidia.com> * update license dates Signed-off-by: M Q <mingmelvinq@nvidia.com> * Updated the copyright year of new files Signed-off-by: M Q <mingmelvinq@nvidia.com> --------- Signed-off-by: M Q <mingmelvinq@nvidia.com>
This was
linked to
issues
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for performing inference on remote Triton Inference Server, with ease of use
Also added the following files to the example application folder:
The Quality Gate failure is due to the example app has duplicated code, which is true as it has exactly the same app inference operator as the Spleen Seg app with in-proc Torch model hosting. We have each example app folder contain all necessary code for ease of use, hence have to tolerate the duplicates with a few hundred lines of code.