Skip to content

Correction for tutorials #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Correction for tutorials #74

wants to merge 5 commits into from

Conversation

Nimajhi
Copy link

@Nimajhi Nimajhi commented May 14, 2025

any other changes needed?

@PhasicFlow
Copy link
Owner

  1. see my comments on the files.
  2. In both tutorial cases, Please create a copy of the file momentumTransport and rename it to turbulenceProperties. At the end we must have two files with the same content and with names: momentumTransport, turbulenceProperties. The first file is used for v9 and the second one is used for v24.
  3. in both cases: delete file blockMeshDict1 under system folder.
  4. Test both cases to see if it runs upto end (at least upto CFD-DEM part)?

PhasicFlow
PhasicFlow reviewed May 15, 2025
View reviewed changes
tutorials/unresolvedGrainPFPisoFoam/fluidizededbed/settings/particlesDict Outdated

// number of particles in the simulation
numPoints 40000;
numPoints 50000;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert this change.

tutorials/unresolvedSpherePFPisoFoam/fluidizededbed/settings/particlesDict Outdated
@@ -28,7 +28,7 @@ positionParticles
randomInfo
{
numPoints 2000;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

numPoints 50000;

tutorials/unresolvedSpherePFPisoFoam/fluidizededbed/settings/particlesDict Outdated
@@ -28,7 +28,7 @@ positionParticles
randomInfo
{
numPoints 2000;
diameter 0.005;
distance 0.005;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

distance 0.0016;

@Nimajhi
Copy link
Author

Nimajhi commented May 15, 2025

The tutorials were tested in two separate folders for versions 9 and 24, and corrections were made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhasicFlow PhasicFlow PhasicFlow left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nimajhi @PhasicFlow