Upgrade to Angular 12 #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the core Angular libraries to Angular version 12. There are also upgrades to various peer dependencies which need to be upgraded to versions compatible with Angular 12, such as ng-bootstrap and shallow-render. This upgrade was performed with the following (long!) command: ``` npx ng update @angular-eslint/builder@12 \ @angular-eslint/eslint-plugin@12 \ @angular-eslint/eslint-plugin-template@12 \ @angular-eslint/schematics@12 \ @angular-eslint/template-parser@12 \ @angular/core@12 @angular/cli@12 @angular/cdk@12 \ @angular/google-maps@12 @angular/compiler-cli@12 \ @angular/language-service@12 @angular/localize@12 \ @angular/animations@12 @angular/common@12 \ @angular/forms@12 @angular/platform-browser@12 \ @angular/router@12 @ng-bootstrap/ng-bootstrap@10 \ shallow-render@12 @angular-devkit/build-angular@12 ``` PER-8853: Upgrade to Angular 12
These changes were automatically added by the Angular-CLI as part of the upgrade process. PER-8853: Upgrade to Angular 12
With Angular and its dependencies upgraded, the Promise on line 97 of `publish.component.ts` creates a compilation error. This can be fixed by specifying the type of the Promise with `Promise<void>` instead of `Promise`. Because of autoformatting, the other changes in this file are just changes from Prettier. PER-8853: Upgrade to Angular 12
With Angular and dependencies upgraded, the `NgbDatepickerConfig` class has changed its `showWeekdays` property to just `weekdays`. This caused a compilation error. Let's fix it. PER-8853: Upgrade to Angular 12
Because of Angular and other dependency upgrades, importing `isArray` from `'util'` causes a compilation error and no longer works. Instead, let's just use the native JavaScript version: `Array.isArray`. This replaces the occurrences of `util.isArray` in the `connector.repo.ts` file. PER-8853: Upgrade to Angular 12
Angular 12 requires `emitDecoratorMetadata` to be set to false in tsconfig, and for some reason it doesn't automatically do this with its migration tool. In addition, remove "commonjs" from `tsconfig.spec.json` to allow tests to work with the upgrade. PER-8853: Upgrade to Angular 12
Previously we were attaching release information to the environment confiuration by importing `version` from Package.json. Because of Angular and other dependency upgrades, importing named exports like this from a JSON file is no longer allowed. Let's instead just import the whole file as an object and refer to its `version` property. PER-8853: Upgrade to Angular 12
liam-lloyd
approved these changes
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades our Angular version from Angular 11 to Angular 12. This includes upgrading Angular's core libraries to version 12, as well as upgrading peer dependencies to versions that are compatible to Angular 12 (such as upgrading
shallow-renderto a newer version that supports Angular 12). Angular-CLI automates some of the migration process, and these automated changes are included in their own commit. In addition, some manual changes needed to be made to get everything working.To test:
npm installAt the current time, one issue is that we do get a bunch of deprecation warnings from Sass when running any builds/tests/dev servers. However, these are currently not breaking changes, only deprecation warnings. Do we want to tackle that in this PR or just add it as an issue to be resolved separately from the main upgrade?
Note: A lot of these deprecation warnings are related to #127 and would be resolved by fixing it.
Resolves PER-8853: Upgrade to Angular 12. This PR also resolves #131, but not the other dependabot PRs at this time. Also resolves #137.