Skip to content

Adding support for password reset. Fix for database has gone away error #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kielstr
Copy link

@kielstr kielstr commented Jun 6, 2017

Hope you don't mind but Ive added support for users to reset their passwords via the Dancer2::Plugin::Auth::Extensible framework. I have also added the code to avoid database has gone away. No caching of db connection.

@kielstr kielstr changed the title Adding support for password rest. Fix for database has gone away error Adding support for password reset. Fix for database has gone away error Jun 6, 2017
@@ -252,6 +252,17 @@ has users_password_column => (
default => 'password',
);

=head2 pw_rest_code_column
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: s/rest/reset/

@yanick
Copy link
Contributor

yanick commented Nov 21, 2017

Could you flesh out the documentation a little more, as well as to add a test exercising the new functionality?

@kielstr
Copy link
Author

kielstr commented Nov 21, 2017 via email

@yanick
Copy link
Contributor

yanick commented Nov 21, 2017

Excellent! Mucho thanks!

@morrisonj
Copy link

Thanks for providing this PR @kielstr :)

I know it's lacking documentation but can this still be merged @yanick ? I'm finding myself in need of the get_user_by_code subroutine in order to get the password reset working properly.

Thanks in advance!

@@ -389,14 +402,44 @@ sub get_user_details {
}
}

=Head2 get_user_by_code

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Head2/head2/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants