Fix binding when user sets HTEx worker ports manually #3838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WardLT
force-pushed
the
fix-zmq-fixed-bindings
branch
3 times, most recently
from
450f44b to
41dd76c
Compare
|
Might I suggest @yadudoc for the review? I altered a function he wrote a few months ago |
|
you might add a case into |
khk-globus
approved these changes
May 7, 2025
khk-globus
force-pushed
the
fix-zmq-fixed-bindings
branch
from
ff7fc22 to
6fe7db2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the creation of the TCP url when the ports used by HTEx workers are fixed.
The
tcp_urlhelper function from addresses.py was only appending the port number when the address was not "*".Changed Behaviour
HTEx works with the ports fixed. Not sure when it was broken
I added a unit test which shows that the current code fails when launching an HTEx interchange with user-set ports.
Fixes
None (yet? should I make one?)
Type of change