Skip to content

feat: Add Google Drive backup sunsetting alert and refactor cloud backup home page #6710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 14 commits into
base: x
Choose a base branch
from
Draft

feat: Add Google Drive backup sunsetting alert and refactor cloud backup home page #6710

wants to merge 14 commits into from

Conversation

limichange
Copy link
Contributor

@limichange limichange commented Feb 20, 2025 •
edited
Loading

Screenshot 2025-04-07 at 10 53 22

@codesandbox CodeSandbox
Copy link

codesandbox bot commented Feb 20, 2025

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 20, 2025 •
edited
Loading

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary or Summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@limichange
Merge branch 'x' into OK-35600
61e7fa2
@limichange
feat: Add cloud backup sunsetting alert toggle in DevSettingsSection
ad3bea5 
* Introduced a new switch for displaying a cloud backup sunsetting alert in the DevSettingsSection.
* Updated the IDevSettings interface to include the new setting.
* Default value for the new setting is set to false.
@limichange limichange removed the wait label Apr 7, 2025
@limichange
fix: Update subtitle for cloud backup sunsetting alert in DevSettings…
d06b97c 
…Section

* Changed the subtitle for the cloud backup sunsetting alert toggle from "展示云备份即将下线的提醒" to "Android & iOS".
@limichange
refactor: Simplify cloud backup sunsetting alert toggle in DevSetting…
49e9147 
…sSection

* Removed the onChange handler and value binding from the cloud backup sunsetting alert switch, streamlining the component's implementation.
@limichange
feat: Integrate cloud backup sunsetting alert toggle in backup process
cba0420 
* Added a check for the cloud backup sunsetting alert setting in DevSettings to conditionally execute cloud backup operations.
* Updated the backupNow method to skip cloud uploads if the alert is enabled, ensuring compliance with user preferences.
@limichange
chore: Update Podfile.lock and Xcode project settings
23370dd 
* Updated RCT-Folly dependency version in Podfile.lock.
* Changed code signing style to Automatic and updated the development team ID in the Xcode project.
* Removed unused provisioning profile specifiers from the project settings.
* Cleaned up unused imports and code in the useBackupToggleDialog component.
@socket-security Socket Security
Copy link

socket-security bot commented Apr 7, 2025 •
edited
Loading

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

@limichange
feat: Add backup now functionality to CloudBackup Home page
bb7c41c 
* Implemented a new button to trigger the backup process immediately.
* Integrated error handling with a toast notification for backup failures.
* Cleaned up unused imports in the useBackupToggleDialog component.
@limichange
refactor: Remove commented-out backup error handling in useBackupTogg…
d516583 
…leDialog

* Cleaned up the useBackupToggleDialog component by removing unused error handling code related to the backup process.
@limichange
feat: Refactor CloudBackup Home page to use new component structure
ef103ff 
* Replaced the existing Home component with a new structure that conditionally renders either NewCloudBackupHome or OldCloudBackupHome based on the cloud backup sunsetting alert setting.
* Introduced new files for NewCloudBackupHome and OldCloudBackupHome, encapsulating their respective functionalities.
* Updated imports and removed unused code to streamline the component's implementation.
@limichange
Merge branch 'x' into OK-35600
7123fe2
@limichange
refactor: Update usePrimeSandboxPayment setting in devSettings atom
b49b865 
* Removed hardcoded false value for usePrimeSandboxPayment and set it to platformEnv.isDev for better environment handling.
* Cleaned up unnecessary whitespace in the devSettings atom.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezailWang ezailWang Awaiting requested review from ezailWang ezailWang will be requested when the pull request is marked ready for review ezailWang is a code owner

@loatheb loatheb Awaiting requested review from loatheb loatheb will be requested when the pull request is marked ready for review loatheb is a code owner

@sidmorizon sidmorizon Awaiting requested review from sidmorizon sidmorizon will be requested when the pull request is marked ready for review sidmorizon is a code owner

@originalix originalix Awaiting requested review from originalix originalix will be requested when the pull request is marked ready for review originalix is a code owner

@huhuanming huhuanming Awaiting requested review from huhuanming huhuanming will be requested when the pull request is marked ready for review huhuanming is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@limichange