Skip to content

Revert remove prior array changes #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

enjuthulung
Copy link
Contributor

Summary:

@enjuthulung enjuthulung requested a review from RaiBnod July 24, 2024 12:10
@RaiBnod
Copy link
Member

RaiBnod commented Jul 24, 2024

Scenario:

The older LoRa point has maintained the priority array. And in the newer one after this commit, it's directly updating the values.

In our point write flow, if priority_array is there it takes the first priority as in here.

As a result, when we edit the LoRa point, the priority_array values get populated in original_value and so in present_value.

So, the fix would be to either keep that priority_array or remove that priority_array completely from LoRa.

Let's keep that priority_array _16.

@Shiny380 do you have any issue maintaining that priority_array 16?

@RaiBnod RaiBnod requested a review from Shiny380 July 24, 2024 13:53
@Shiny380
Copy link
Contributor

nah I don't care how it's implemented. worth noting that the priority array is irrelevant to lora so whatever is the simplest fix :)
please make sure it's tested before merging. use a controller in the office

@RaiBnod RaiBnod merged commit b531cec into master Jul 25, 2024
2 checks passed
@RaiBnod RaiBnod deleted the improvement/revert-remove-prior-array branch July 25, 2024 08:28
@RaiBnod RaiBnod mentioned this pull request Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants