Skip to content

Switch workspace on invitation accepted #3895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

VitorVieiraZ
Copy link
Contributor

@VitorVieiraZ VitorVieiraZ commented May 12, 2025

  • Added workspaceId to InvitationsModel after /v1/workspace/invitations endpoint began including this field with each invitation. After accepting a workspace invitation, app now switches to accepted workspace and navigates to its project list if server version is bigger than 2025.4.1 ( see https://github.com/MerginMaps/server-private/issues/2936 ).
  • Added a new method serverVersionIsAtLeast to check whether server version meets or exceeds a required minimum version.
  • Changed icon of addIcon method in NotificationModel from WaitingIcon to InfoIcon.

Resolves #3847

@VitorVieiraZ VitorVieiraZ added the FROZEN 🥶 do not merge before upcoming release label May 13, 2025
@VitorVieiraZ
Copy link
Contributor Author

We should wait for server release before testing and merging this PR.

@VitorVieiraZ VitorVieiraZ force-pushed the enhance-invitation-accept branch from 3b1a008 to 7c5df2d Compare May 15, 2025 07:26
Copy link

github-actions bot commented May 15, 2025

Pull Request Test Coverage Report for Build 15045491239

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 105 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.01%) to 60.411%

Files with Coverage Reduction New Missed Lines %
input/core/merginuserinfo.h 1 0.0%
input/core/merginuserinfo.cpp 4 74.65%
input/app/invitationsmodel.cpp 25 0.0%
input/core/merginapi.cpp 75 78.62%
Totals Coverage Status
Change from base Build 15018608869: 0.01%
Covered Lines: 8167
Relevant Lines: 13519

💛 - Coveralls

@VitorVieiraZ VitorVieiraZ changed the title WIP - Switch workspace on invitation accepted Switch workspace on invitation accepted May 15, 2025
Copy link
Collaborator

@tomasMizera tomasMizera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to what we agreed on the call :)

@VitorVieiraZ
Copy link
Contributor Author

Working on app.dev tests.

@VitorVieiraZ VitorVieiraZ requested a review from tomasMizera June 2, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FROZEN 🥶 do not merge before upcoming release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Open the list of workspace projects after accepting invitation
3 participants