Fix Reuse last entered value tool and QGIS's reuseLastValue support #3788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 14105187091Details
💛 - Coveralls |
VitorVieiraZ
changed the title
VitorVieiraZ
force-pushed
the
fix/rememberAttributesController
branch
from
c683cc4 to
34d2131
Compare
VitorVieiraZ
changed the title
VitorVieiraZ
changed the title
uclaros
force-pushed
the
fix/rememberAttributesController
branch
from
ae22d87 to
c756428
Compare
uclaros
changed the title
|
Testing looks good to me. The only scenario to confirm, that is set this way now: if we have a project with |
Store invalid QVariant() in settings when remember value is unchecked Store empty QString() or actual value when is checked Check the status in qgis form config when our global switch is off or when we don't have an entry in the settings.
|
|
|
Hi @uclaros - is this one ready for review please? |
tomasMizera
requested changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for QGIS's native
reuseLastValueoption and refactoring ofRememberAttributesControllerto store attribute values persistently in QSettings instead of in-memory, making them survive reinstantiation on each new form open. This adds project-specific storage withActiveProjectintegration. On project deletion, stored settings fromRememberAttributesControllerare cleared.Fix #3784