remove B+ Tree implementation #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…romotion, and key-based access - **Adjusted `BPlusTreeInternalNode::insert()` Method:** - Corrected the insertion logic to maintain proper alignment between `keys` and `children` arrays. - Ensured that when a child node splits, the promoted key is inserted into the current node's `keys`, and the new child node is correctly placed in the `children` array. - **Modified `split()` Methods in Nodes:** - Updated `BPlusTreeInternalNode::split()` to correctly calculate the middle index and properly split `keys` and `children` arrays. - Promoted the appropriate key to the parent node during splits. - Ensured that each internal node maintains the B+ Tree properties after splitting. - Adjusted `BPlusTreeLeafNode::split()` to handle small orders and maintain the linked list of leaf nodes. - **Updated Tree Size Management:** - Incremented the `size` property in the `BPlusTree` class during insertions to accurately reflect the number of elements. - Fixed issues where the `size` was not updated, causing `OutOfRangeException` errors. - **Revised `set` and `get` Methods:** - Changed `set` and `get` methods to operate on keys rather than indices, aligning with the key-based nature of B+ Trees. - Updated `set` to traverse the tree and update the value associated with a given key. - Modified `get` to retrieve the value based on the key, throwing an exception if the key is not found. - **Fixed Test Cases:** - Adjusted `testVisualTreeStructure` to insert enough keys to cause node splitting, ensuring both internal and leaf nodes are present. - Updated `testGetOrder` by correcting the `order` property assignment in the `BPlusTree` class, matching expected values in tests. - Renamed and modified `testSetAndGetByIndex` to `testSetAndGetByKey`, reflecting the changes in method functionality. - **Improved Code Consistency and Documentation:** - Removed redundant property declarations and assignments in the `BPlusTree` constructor. - Ensured consistent use of the `order` property throughout the class. - Added comments and documentation to clarify method purposes and enhance readability. - Ensured alignment between method implementations and their intended use cases. **Summary:** These corrections address critical issues in the B+ Tree implementation related to node splitting, key promotion, and data access by keys. By refining the logic in node insertion and splitting methods, the tree now correctly maintains its balanced structure and properties, even with small orders. The `size` property accurately tracks the number of elements, preventing out-of-range errors. The `set` and `get` methods now intuitively operate on keys, improving usability. Tests have been updated to reflect these changes, ensuring the reliability and correctness of the implementation.
- Restructured methods in `BPlusTree`, `BPlusTreeInternalNode`, and `BPlusTreeLeafNode` classes to enhance code clarity and organization. - Removed redundant code and simplified logical conditions for better performance. - Standardized variable and method naming conventions for consistency throughout the codebase. - Updated tests in `BPlusTreeTest.php` to reflect the changes made to the classes and ensure functional integrity. - Prepared the code for future enhancements and extensions in the B+ Tree implementation. - Added `BPlusTreeSearcherTest.php` (untracked file) for additional testing of search functionality.'
The current implementation of the B+ Tree contains critical logical issues, particularly in tree balancing and search operations. All related classes and tests have been removed to prevent further issues. The algorithm will be rewritten in the future with a more robust approach. Removed files include:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove B+ Tree implementation due to logical errors](595db62)