Skip to content

Avoid allocations in fmap #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2025
Merged

Conversation

fhagemann
Copy link
Contributor

@fhagemann fhagemann commented Apr 22, 2025

Should fix #610 (the exact error reported therein), but there might also be some other functions that might have introduced allocations going from julia-1.10 to julia-1.11

Copy link

codecov bot commented Apr 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.73%. Comparing base (fab0496) to head (dd288a8).
Report is 28 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #618      +/-   ##
==========================================
+ Coverage   87.07%   87.73%   +0.65%     
==========================================
  Files          28       29       +1     
  Lines        1888     1908      +20     
==========================================
+ Hits         1644     1674      +30     
+ Misses        244      234      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mkitti
Copy link
Collaborator

mkitti commented Apr 22, 2025

Thank you. This looks pretty straightforward.

I'm currently in the process of trying to straighten out CI, but I have this in my queue to review.

@fhagemann
Copy link
Contributor Author

I mean full credit goes to @N5N3 for coming up with this solution!

@mkitti mkitti merged commit 0494222 into JuliaMath:master May 7, 2025
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interpolations.gradient is not allocation free under Julia v1.11
2 participants