-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat(modelarmor): #14 Added snippets for update template with mask config #5280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…eleting model armor templates
…eleting modelarmor templates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @tirthrajsinh-zala-crest, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request introduces a new sample for updating a Model Armor template with a mask configuration. It includes the addition of new files related to Model Armor, such as create_template.go
, go.mod
, go.sum
, modelarmor_test.go
, testdata/env/test.env
, and update_template_with_mask_configuration.go
. The changes demonstrate how to create and update Model Armor templates with specific filter configurations using the cloud.google.com/go/modelarmor
library.
Highlights
- New Model Armor Sample: Adds a complete sample for creating and updating Model Armor templates, showcasing the usage of mask configurations for targeted updates.
- Template Creation: Introduces
create_template.go
, which provides a function to create a new Model Armor template with specified filters for PI, jailbreak attempts, and malicious URIs. - Template Update with Mask: Implements
update_template_with_mask_configuration.go
, demonstrating how to update a template's filter configuration using a field mask to avoid overwriting other settings. - Dependencies: Adds necessary dependencies in
go.mod
andgo.sum
for the Model Armor API and related utilities. - Testing: Includes a test case in
modelarmor_test.go
to verify the update template with mask configuration functionality.
Changelog
Click here to see the changelog
- go.work
- Added the
./modelarmor
directory to the go workspace.
- Added the
- modelarmor/create_template.go
- Created a new file with a sample function
createModelArmorTemplate
to create a Model Armor template. - The function sets up filters for PI, jailbreak attempts, and malicious URIs.
- It uses the
cloud.google.com/go/modelarmor
library to interact with the Model Armor API.
- Created a new file with a sample function
- modelarmor/go.mod
- Created a new go module for the Model Armor sample.
- Added dependencies for
cloud.google.com/go/modelarmor
,google.golang.org/api
,google.golang.org/grpc
, and other utility libraries.
- modelarmor/go.sum
- Generated the go sum file to lock the dependencies.
- modelarmor/modelarmor_test.go
- Created a new test file for the Model Armor sample.
- Added a test case
TestUpdateTemplateWithMaskConfiguration
to verify the update template with mask configuration functionality. - Includes helper functions for setting up the test environment and cleaning up resources.
- modelarmor/testdata/env/test.env
- Created a test environment file to store environment variables for testing.
- modelarmor/update_template_with_mask_configuration.go
- Created a new file with a sample function
updateModelArmorTemplateWithMaskConfiguration
to update a Model Armor template using a mask configuration. - The function updates the template's filter configuration, specifically the RAI and SDP settings.
- It uses a field mask to specify which fields to update.
- Created a new file with a sample function
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
A template's form,
Filters masked, a focused storm,
RAI and SDP.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request introduces new samples for creating and updating Model Armor templates. The code appears well-structured and includes necessary error handling and documentation. However, there are a few areas that could be improved for clarity and efficiency.
Summary of Findings
- Error message formatting: The error messages could be improved by including the template ID for easier debugging.
- Redundant client creation: The test suite creates the client multiple times, which can be optimized by creating it once and reusing it.
Merge Readiness
The pull request is almost ready for merging. Addressing the error message formatting and client creation redundancy would improve the code quality. I am unable to directly approve the pull request, and users should have others review and approve this code before merging. I recommend addressing the comments before merging.
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR has the same global issues as #5273 . Please re-open once all issues have been addressed.
Description
Added sample for update template with mask config
Checklist
go test -v ./..
(see Testing)gofmt
(see Formatting)go vet
(see Formatting)