Use a typescript class to improve the typing #153
+273
−122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this change `this` was typed as any so typescript couldn't check the code very well. With this change several edge cases were identified and addressed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change
thiswas typed asanyso typescript couldn't check the code very well.With this change several edge cases were identified and addressed.
I haven't tested this specific code. I did this refactoring in my own codebase first and it worked fine for how we are using it. I did this refactoring so I could more safely strip down the layer to just what we need in our use case. I probably won't be able to spend more time on the code of this PR, but I wanted to contribute it in case you find it useful.