-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Findchat group name treatment #1420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ajusta para endpoint puxa o nome do grupo correntemente quando for grupo usando nomenclatura @g.us
Reviewer's GuideThis pull request modifies a SQL query within Entity Relationship Diagram: Updated 'pushName' SourceerDiagram
TITLE "ER Diagram: Change in pushName Data Source"
Contact ||--o{ Chat : "related via remoteJid (implied)"
Contact {
string id PK
string remoteJid UK
string pushName "<- Previously used for alias"
string profilePicUrl
}
Chat {
string name "<- Now used for 'pushName' alias"
string remoteJid UK "Implied join key"
}
Message {
bigint messageTimestamp "Used in COALESCE"
}
Contact ||--o{ Message : "related (implied by query)"
note "The query alias 'pushName' now sources data from Chat.name instead of Contact.pushName."
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @luiis716 - I've reviewed your changes - here's some feedback:
- Ensure using
Chat.name
is correct for individual chats as well, not just groups identified by@g.us
. - Consider if the
pushName
alias should be renamed now that it sources fromChat.name
.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Estava na branch main, na mudança para a develop gereu conflitos, corrija por favor |
ajusta para endpoint puxa o nome do grupo correntemente quando for grupo usando nomenclatura @g.us
Summary by Sourcery
Enhancements: