Skip to content

Findchat group name treatment #1420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 13, 2025
Merged

Conversation

luiis716
Copy link

@luiis716 luiis716 commented May 5, 2025

ajusta para endpoint puxa o nome do grupo correntemente quando for grupo usando nomenclatura @g.us

Summary by Sourcery

Enhancements:

  • Update SQL query to fetch group chat name instead of contact's push name for group chats

ajusta para endpoint puxa o nome do grupo correntemente quando for grupo usando nomenclatura @g.us
Copy link

sourcery-ai bot commented May 5, 2025

Reviewer's Guide

This pull request modifies a SQL query within ChannelStartupService to correctly retrieve group names. It changes the source for the pushName alias from the Contact table's pushName column to the Chat table's name column.

Entity Relationship Diagram: Updated 'pushName' Source

erDiagram
    TITLE "ER Diagram: Change in pushName Data Source"
    Contact ||--o{ Chat : "related via remoteJid (implied)"
    Contact {
        string id PK
        string remoteJid UK
        string pushName "<- Previously used for alias"
        string profilePicUrl
    }
    Chat {
        string name "<- Now used for 'pushName' alias"
        string remoteJid UK "Implied join key"
    }
    Message {
        bigint messageTimestamp "Used in COALESCE"
    }
    Contact ||--o{ Message : "related (implied by query)"

    note "The query alias 'pushName' now sources data from Chat.name instead of Contact.pushName."
Loading

File-Level Changes

Change Details Files
Updated SQL query to use Chat.name for pushName alias.
  • Modified the SELECT statement to fetch Chat.name instead of Contact.pushName for the pushName field when querying contact/chat details.
src/api/services/channel.service.ts

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @luiis716 - I've reviewed your changes - here's some feedback:

  • Ensure using Chat.name is correct for individual chats as well, not just groups identified by @g.us.
  • Consider if the pushName alias should be renamed now that it sources from Chat.name.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@DavidsonGomes DavidsonGomes changed the base branch from main to develop May 10, 2025 13:29
@DavidsonGomes
Copy link
Collaborator

Estava na branch main, na mudança para a develop gereu conflitos, corrija por favor

@DavidsonGomes DavidsonGomes merged commit 6d63f2f into EvolutionAPI:develop May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants