Restrict the SQL database creation to the config directory #4521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Discookie
force-pushed
the
sqlite-db
branch
5 times, most recently
from
3651aee to
381f48e
Compare
bruntib
requested changes
May 7, 2025
docs/web/products.md
Outdated
| @@ -26,6 +26,8 @@ further details. | |||
| The Web application separates products based on their unique endpoint. The | |||
| home page of the server is the product list, shown above. | |||
|
|
|||
| ** | |||
|
|
|||
There was a problem hiding this comment.
This is probably accidental.
Discookie
force-pushed
the
sqlite-db
branch
4 times, most recently
from
a450871 to
8355794
Compare
Previously, SQL files could be created anywhere on the server. This change restricts them always to inside the config directory. To use SQL databases in other locations, create a symlink inside the config directory.
bruntib
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, SQL files could be created anywhere on the server. This change restricts them always to inside the config directory.
The old behavior can be brought back by creating symlinks manually in the config dir.