Skip to content

Sketch distribute fix #1826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 9, 2025
Merged

Sketch distribute fix #1826

merged 4 commits into from
May 9, 2025

Conversation

adam-urbanczyk
Copy link
Member

@adam-urbanczyk adam-urbanczyk commented Apr 25, 2025

Fixes #1819

@adam-urbanczyk adam-urbanczyk marked this pull request as draft April 25, 2025 07:09
@adam-urbanczyk adam-urbanczyk linked an issue Apr 25, 2025 that may be closed by this pull request
Copy link

codecov bot commented May 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.62%. Comparing base (8c68faa) to head (182795a).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1826      +/-   ##
==========================================
+ Coverage   95.54%   95.62%   +0.08%     
==========================================
  Files          28       28              
  Lines        7319     7937     +618     
  Branches     1102     1262     +160     
==========================================
+ Hits         6993     7590     +597     
- Misses        195      210      +15     
- Partials      131      137       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@adam-urbanczyk adam-urbanczyk requested a review from lorenzncode May 5, 2025 13:27
@adam-urbanczyk
Copy link
Member Author

Does that look good to you @lorenzncode ?

@lorenzncode
Copy link
Member

Does that look good to you @lorenzncode ?

Yes, looks good!

@adam-urbanczyk adam-urbanczyk requested a review from jmwright May 6, 2025 06:59
@adam-urbanczyk adam-urbanczyk marked this pull request as ready for review May 6, 2025 06:59
Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adam-urbanczyk !

@adam-urbanczyk adam-urbanczyk merged commit 9bd1cb6 into master May 9, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sketch distribute on segment fails
3 participants