-
Notifications
You must be signed in to change notification settings - Fork 328
WIP: non-blocking show using trame/vtk #1786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1786 +/- ##
==========================================
- Coverage 95.47% 95.47% -0.01%
==========================================
Files 28 28
Lines 7188 7187 -1
Branches 1080 1082 +2
==========================================
- Hits 6863 6862 -1
Misses 195 195
Partials 130 130 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@jmwright @lorenzncode I'm not saying this is ready, but would you be able to give this a try? Just to collect some datapoints on possible issues... |
I tested on linux.
|
OK I forgot you probably intend this to be run from ipython. In that case the server does stay running. |
I created a new venv for the changes and installed via pip, and it seems to work. Two corrections for your sample code at top. from cadquery.fig import Figure() should be... from cadquery.fig import Figure and fit.clear() should be... fig.clear() The server continued to run when started by entering the code into the Python REPL and all updates showed up in the 3D viewer. The mouse rotation of the scene is a little laggy, even though my laptop does not normally struggle with 3D rendering. Debian 12, AMD64, local install via pip. |
Thanks for the feedback.
|
Yes, that's correct. It works fine with cadquery.vis and cq-editor (and I expect this PR after adding a browser). I only meant that if this was a server it could be an alternative display method which might have some advantages. Sorry to get off topic. Here is how I use the container today:
Then in container run script: podman run -it --entrypoint=/bin/bash --userns=keep-id \
--security-opt label=type:container_runtime_t \
-e XDG_RUNTIME_DIR=/tmp \
-e DISPLAY=${display} \
-e "WAYLAND_DISPLAY=$way_display" \
-v /run/user/$user_uid/${way_display}:/tmp/${way_display} \
-v "$XDG_RUNTIME_DIR/${way_display}:/tmp/${way_display}" \
-v /tmp/.X11-unix/${x_socket}:/tmp/.X11-unix/${x_socket} \
... |
Closes #1784 (?)
API: