-
Notifications
You must be signed in to change notification settings - Fork 328
Add STEP Import for Assemblies #1779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1779 +/- ##
==========================================
- Coverage 95.54% 95.42% -0.12%
==========================================
Files 28 29 +1
Lines 7319 7396 +77
Branches 1102 1114 +12
==========================================
+ Hits 6993 7058 +65
- Misses 195 202 +7
- Partials 131 136 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@adam-urbanczyk In 4045c58 you set the We need to decide on the proper way to fix this. |
Hey, I do not understand the issue. You can always do this:
Do you mean that you need to modify |
Correct, mypy complains. I can make that change to make |
The goal is to make it possible to round-trip assemblies to and from STEP without loss of data. This data can include: