Explicitly request type when using nerc_rates #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuanMPhm
reviewed
Apr 30, 2025
requirements.txt
Outdated
| @@ -1,3 +1,4 @@ | |||
| git+https://github.com/CCI-MOC/nerc-rates@33701ed#egg=nerc_rates | |||
There was a problem hiding this comment.
@naved001 Is it fine if we use a github url instead of the zip file?
@KelvinLinBU Based on the failed CI, the Docker image being used does not contain git, hence why we're getting nerc-rates through a zip file. Please use the zip file.
There was a problem hiding this comment.
And could you put the line in the same order. The diff becomes a bit confusing when things get shuffled around
There was a problem hiding this comment.
I guess just don't change this file at all?
KelvinLinBU
force-pushed
the
update-get-value-at
branch
3 times, most recently
from
f862d9c to
86ebe3b
Compare
QuanMPhm
reviewed
Apr 30, 2025
requirements.txt
Outdated
| @@ -1,3 +1,3 @@ | |||
| requests>=2.18.4 | |||
| boto3<1.36 | |||
| https://github.com/CCI-MOC/nerc-rates/archive/main.zip | |||
| https://github.com/CCI-MOC/nerc-rates/archive/main.zip | |||
There was a problem hiding this comment.
You removed a newline here?
With the recent update to `nerc_rates` [1] which added type enforcement and requires users of `nerc_rates` to explicitly declare the requested type, our script has been updated to request the appropriate types. This should reduce ambiguity in the values we fetch from nerc_rates [1] CCI-MOC/nerc-rates#22
KelvinLinBU
force-pushed
the
update-get-value-at
branch
from
86ebe3b to
d3bf75a
Compare
QuanMPhm
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the recent update to
nerc_rates[1] which added type enforcement and requires users ofnerc_ratesto explicitly declare the requested type, our script has been updated to request the appropriate types. This should reduce ambiguity in the values we fetch from nerc_rates. Update requirements.txt to newest nerc-rates version.[1] CCI-MOC/nerc-rates#22