Create the msal-custom-auth package for supporting the external ID authentication (sign-in, sign-up and SSPR) #7599

shenj · 2025-02-26T21:42:25Z

The changes in this PR include:

Create the msal-custom-auth package for supporting the external ID authentication (sign-in, sign-up and SSPR).
integrate the msal-custom-auth package into the pipelines
Expose more components from msal-browser which are used by the new package msal-custom-auth.

- Add msal-custom-auth to pipeline

…ft-authentication-library-for-js into jiashen/sketeton

shenj · 2025-04-08T13:54:46Z

.pipelines/1p-build.yml

@@ -22,7 +22,7 @@ resources:
        - repository: 1P
          type: git
          name: IDDP/msal-javascript-1p
-          ref: master
+          ref: custom-auth/pipeline # TODO: change back to master after pipeline is working


This change will be reverted after the ADO PR is completed.

shenj · 2025-04-08T13:55:08Z

.pipelines/3p-e2e.yml

@@ -50,7 +54,7 @@ resources:
        - repository: 1P
          type: git
          name: IDDP/msal-javascript-1p
-          ref: master
+          ref: custom-auth/pipeline # TODO: change back to master after pipeline is working


This change will be reverted after the ADO PR is completed.

This PR is to add support for web fallback for (sign-up, sign-in, reset password) flows. 1. Existing code already check during those flows if challenge types is `redirect `only. In this case, user could check this condition from state, and handle it. 2. By default, user could reuse the built-in `popUpLogin` from MSAL JS to continue to flow with a pop up interactively. 3. Make sure challenge type at least contains `redirect`.

tnorling · 2025-04-17T18:11:06Z

lib/msal-browser/src/index.ts

@@ -18,6 +18,7 @@ export {
 } from "./app/PublicClientApplication.js";
 export { PublicClientNext } from "./app/PublicClientNext.js";
 export { IController } from "./controllers/IController.js";
+export { StandardController } from "./controllers/StandardController.js";


Please don't add these exports, these are internal to msal-browser and are not API stable, thus not intended to be public. Let's figure out how we can enable your scenarios in a way that uses the existing public surface where possible and expose new APIs that can be properly supported where the existing APIs have gaps. Feel free to reach out if you have questions on this.

tnorling · 2025-04-18T17:02:06Z

lib/msal-custom-auth/src/get_account/interaction_client/CustomAuthSilentCacheClient.ts

+        try {
+            this.logger.verbose("Starting silent flow to acquire token from cache", this.correlationId);
+
+            const result = await silentFlowClient.acquireCachedToken(silentRequest);


This can be changed to <PublicClientApplication instance>.acquireTokenSilent({...silentRequest, cacheLookupPolicy: CacheLookupPolicy.AccessToken})

tnorling · 2025-04-18T17:03:35Z

lib/msal-custom-auth/src/get_account/interaction_client/CustomAuthSilentCacheClient.ts

+
+                this.logger.verbose("Starting refresh flow to refresh token", this.correlationId);
+
+                const refreshTokenResult = await refreshTokenClient.acquireTokenByRefreshToken(silentRequest);


This can be changed to <PublicClientApplication instance>.acquireTokenSilent({...silentRequest, cacheLookupPolicy: CacheLookupPolicy.RefreshToken})

tnorling · 2025-04-18T17:04:28Z

lib/msal-custom-auth/src/get_account/interaction_client/CustomAuthSilentCacheClient.ts

+        }
+    }
+
+    override async logout(logoutRequest?: ClearCacheRequest): Promise<void> {


Reason you can't use the existing logoutRedirect API as-is?

tnorling · 2025-04-18T17:05:03Z

lib/msal-custom-auth/src/get_account/interaction_client/CustomAuthSilentCacheClient.ts

+
+        this.logger.verbose("Getting the first account from cache.", correlationId);
+
+        const allAccounts = this.browserStorage.getAllAccounts();


This can be changed to <PublicClientApplication instance>.getAllAccounts()

Jian Shen and others added 30 commits November 8, 2024 10:02

Skeleton

eeee622

Commit

897677b

Commit

8972d9e

Commit

bedfd47

Refactor 1

55de7d9

Update for design doc

b228f19

Commit

74b4431

rename design doc

6c863f5

Design update

cb321c9

Commit

fc59df0

Remove the design doc

09e1b25

ignore build output

4ba880b

Updates for feedbacks

35b4cee

Commit

c589ec1

Commit

c78a870

Restructure folders

284cee0

rename package

238a289

Rename

fd0514e

feedbacks

d80be99

- Setup msal-custom-auth sample for e2e

f259b87

- Add msal-custom-auth to pipeline

Merge branch 'jiashen/sketeton' of https://github.com/AzureAD/microso…

e5d113b

…ft-authentication-library-for-js into jiashen/sketeton

Commit

8821c6b

Merge branch 'dev' into jiashen/sketeton

0d7e08e

Change build command

1546766

Update packages

7bef47c

Alter build:all

360914d

Change files

9c63cbf

Fix lint and alter build:all

0f9a609

Change package

a43a3e7

Modify build:all

a4456af

github-actions bot added the extensions Related to extensions for the base libraries label Apr 2, 2025

shenj added 2 commits April 2, 2025 21:24

package lock fix

37b3172

Merge remote-tracking branch 'origin/dev' into custom-auth/main

4f38594

github-actions bot removed msal-angular Related to @azure/msal-angular package msal-node Related to msal-node package msal-common Related to msal-common package msal-react Related to @azure/msal-react extensions Related to extensions for the base libraries labels Apr 2, 2025

Change files

2314a2c

shenj marked this pull request as ready for review April 8, 2025 13:35

shenj requested review from hectormmg, tnorling, peterzenz, sameerag, konstantin-msft, jo-arroyo, lalimasharda, shylasummers, bgavrilMS and Robbie-Microsoft as code owners April 8, 2025 13:35

shenj changed the title ~~Custom auth/main~~ Create the msal-custom-auth package for the external ID authentication (sign-in, sign-up and SSPR) Apr 8, 2025

shenj changed the title ~~Create the msal-custom-auth package for the external ID authentication (sign-in, sign-up and SSPR)~~ Create the msal-custom-auth package for supporting the external ID authentication (sign-in, sign-up and SSPR) Apr 8, 2025

shenj commented Apr 8, 2025

View reviewed changes

tnorling reviewed Apr 17, 2025

View reviewed changes

tnorling reviewed Apr 18, 2025

View reviewed changes

microsoft-github-policy-service bot added the Needs: Attention 👋 Awaiting response from the MSAL.js team label May 5, 2025

Merge remote-tracking branch 'origin/dev' into custom-auth/main

5a47e18

microsoft-github-policy-service bot removed the Needs: Attention 👋 Awaiting response from the MSAL.js team label May 16, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create the msal-custom-auth package for supporting the external ID authentication (sign-in, sign-up and SSPR) #7599

Create the msal-custom-auth package for supporting the external ID authentication (sign-in, sign-up and SSPR) #7599

shenj commented Feb 26, 2025 •

edited

Loading

shenj Apr 8, 2025

shenj Apr 8, 2025

tnorling Apr 17, 2025

tnorling Apr 18, 2025

tnorling Apr 18, 2025

tnorling Apr 18, 2025

tnorling Apr 18, 2025


		this.logger.verbose("Starting refresh flow to refresh token", this.correlationId);

		const refreshTokenResult = await refreshTokenClient.acquireTokenByRefreshToken(silentRequest);


		this.logger.verbose("Getting the first account from cache.", correlationId);

		const allAccounts = this.browserStorage.getAllAccounts();

Create the msal-custom-auth package for supporting the external ID authentication (sign-in, sign-up and SSPR) #7599

Are you sure you want to change the base?

Create the msal-custom-auth package for supporting the external ID authentication (sign-in, sign-up and SSPR) #7599

Conversation

shenj commented Feb 26, 2025 • edited Loading

shenj Apr 8, 2025

Choose a reason for hiding this comment

shenj Apr 8, 2025

Choose a reason for hiding this comment

tnorling Apr 17, 2025

Choose a reason for hiding this comment

tnorling Apr 18, 2025

Choose a reason for hiding this comment

tnorling Apr 18, 2025

Choose a reason for hiding this comment

tnorling Apr 18, 2025

Choose a reason for hiding this comment

tnorling Apr 18, 2025

Choose a reason for hiding this comment

shenj commented Feb 26, 2025 •

edited

Loading