Skip to content

Handle account removed suberror in brokers and MSALs #1520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

antonioalwan
Copy link
Contributor

Proposed changes

Ensuring that any remaining artifacts on the device for deleted user accounts are removed when ESTS returns the suberror=user_account_deleted. This fix should be applied in the common core where Brokers and MSALs are addressed.
Added TestFlight entry: "disable_remove_account_artifacts"

Type of change

  • Feature work
  • Bug fix
  • Documentation
  • Engineering change
  • Test
  • Logging/Telemetry

Risk

  • High – Errors could cause MAJOR regression of many scenarios. (Example: new large features or high level infrastructure changes)
  • Medium – Errors could cause regression of 1 or more scenarios. (Example: somewhat complex bug fixes, small new features)
  • Small – No issues are expected. (Example: Very small bug fixes, string changes, or configuration settings changes)

Additional information

WILink: https://identitydivision.visualstudio.com/Engineering/_workitems/edit/3168316

@antonioalwan antonioalwan requested a review from a team as a code owner May 1, 2025 18:56
@@ -215,4 +215,15 @@ extern NSString * _Nonnull const MSID_FLIGHT_USE_V2_WEB_RESPONSE_FACTORY;
extern NSString * _Nonnull const MSID_FLIGHT_SUPPORT_DUNA_CBA;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not update changelog.txt.

Please consider if this change would be noticeable to a partner or user and either update changelog.txt or resolve this conversation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant