-
Notifications
You must be signed in to change notification settings - Fork 36
Add New Error Codes and Util Class for MSA DR Work #2533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fadidurah
wants to merge
18
commits into
fadi/MSA-DR-base
Choose a base branch
from
fadi/msa-util
base: fadi/MSA-DR-base
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 17 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
e87d634
msa support
fadidurah f965726
add method to check authority
fadidurah e70a685
adjust method
fadidurah 90b67c5
update jwt utils
fadidurah 57fe0c3
Implement methods in JwtUtils
fadidurah 3c29885
add tests for util classes
fadidurah 543667a
new line
fadidurah a0c364e
minor
fadidurah 1bc1757
minor update
fadidurah 54618cf
Merge branch 'dev' of https://github.com/AzureAD/microsoft-authentica…
fadidurah 6bec55e
Update common4j/src/main/com/microsoft/identity/common/java/exception…
fadidurah f1e51c7
com
fadidurah 329c39f
Merge branch 'fadi/msa-util' of https://github.com/AzureAD/microsoft-…
fadidurah 8c0f7d4
some more exceptions
fadidurah 818eeda
some more exceptions
fadidurah dd80ea8
some more exceptions
fadidurah b884291
remove fields
fadidurah 98c9a49
nullability
fadidurah File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
53 changes: 53 additions & 0 deletions
53
common4j/src/main/com/microsoft/identity/common/java/util/MsaUtil.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
// Copyright (c) Microsoft Corporation. | ||
// All rights reserved. | ||
// | ||
// This code is licensed under the MIT License. | ||
// | ||
// Permission is hereby granted, free of charge, to any person obtaining a copy | ||
// of this software and associated documentation files(the "Software"), to deal | ||
// in the Software without restriction, including without limitation the rights | ||
// to use, copy, modify, merge, publish, distribute, sublicense, and / or sell | ||
// copies of the Software, and to permit persons to whom the Software is | ||
// furnished to do so, subject to the following conditions : | ||
// | ||
// The above copyright notice and this permission notice shall be included in | ||
// all copies or substantial portions of the Software. | ||
// | ||
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
// THE SOFTWARE. | ||
package com.microsoft.identity.common.java.util | ||
|
||
import com.microsoft.identity.common.java.authorities.Authority | ||
import com.microsoft.identity.common.java.authorities.AzureActiveDirectoryAudience | ||
import com.microsoft.identity.common.java.authorities.AzureActiveDirectoryAuthority | ||
import java.util.Locale | ||
|
||
/** | ||
* Class for various MSA-related utility methods. | ||
*/ | ||
class MsaUtil { | ||
|
||
companion object { | ||
val jwtPurpose = "v2sso" | ||
|
||
/** | ||
* Given an authority, check if this is an MSA request | ||
*/ | ||
fun isMsaRequest(authority : Authority) : Boolean { | ||
return if (authority !is AzureActiveDirectoryAuthority) { | ||
false | ||
} else { | ||
// authority has been silently casted to AzureActiveDirectoryAuthority | ||
val audience = authority.mAudience.tenantId.lowercase(Locale.ROOT) | ||
|
||
// Check if audience is consumers or the MSA Mega Tenant | ||
audience == AzureActiveDirectoryAudience.MSA_MEGA_TENANT_ID || audience == AzureActiveDirectoryAudience.CONSUMERS | ||
} | ||
} | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
61 changes: 61 additions & 0 deletions
61
common4j/src/test/com/microsoft/identity/common/java/util/MsaUtilTest.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
// Copyright (c) Microsoft Corporation. | ||
// All rights reserved. | ||
// | ||
// This code is licensed under the MIT License. | ||
// | ||
// Permission is hereby granted, free of charge, to any person obtaining a copy | ||
// of this software and associated documentation files(the "Software"), to deal | ||
// in the Software without restriction, including without limitation the rights | ||
// to use, copy, modify, merge, publish, distribute, sublicense, and / or sell | ||
// copies of the Software, and to permit persons to whom the Software is | ||
// furnished to do so, subject to the following conditions : | ||
// | ||
// The above copyright notice and this permission notice shall be included in | ||
// all copies or substantial portions of the Software. | ||
// | ||
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
// THE SOFTWARE. | ||
package com.microsoft.identity.common.java.util | ||
|
||
import com.microsoft.identity.common.java.authorities.AccountsInOneOrganization | ||
import com.microsoft.identity.common.java.authorities.AzureActiveDirectoryAudience | ||
import com.microsoft.identity.common.java.authorities.AzureActiveDirectoryAuthority | ||
import com.microsoft.identity.common.java.authorities.AzureActiveDirectoryB2CAuthority | ||
import org.junit.Assert | ||
import org.junit.Test | ||
|
||
class MsaUtilTest { | ||
|
||
@Test | ||
fun isMsaRequestWithMsaMegaTenantAuthority() { | ||
val msaMegaTenantAuthority = AzureActiveDirectoryAuthority(AccountsInOneOrganization(AzureActiveDirectoryAudience.MSA_MEGA_TENANT_ID)) | ||
|
||
Assert.assertTrue(MsaUtil.isMsaRequest(msaMegaTenantAuthority)) | ||
} | ||
|
||
@Test | ||
fun isMsaRequestWithConsumersAuthority() { | ||
val consumersTenantAuthority = AzureActiveDirectoryAuthority(AccountsInOneOrganization(AzureActiveDirectoryAudience.CONSUMERS)) | ||
|
||
Assert.assertTrue(MsaUtil.isMsaRequest(consumersTenantAuthority)) | ||
} | ||
|
||
@Test | ||
fun isMsaRequestWithNonMsaAuthority() { | ||
val nonMsaAuthority = AzureActiveDirectoryAuthority(AccountsInOneOrganization(AzureActiveDirectoryAudience.ALL)) | ||
|
||
Assert.assertFalse(MsaUtil.isMsaRequest(nonMsaAuthority)) | ||
} | ||
|
||
@Test | ||
fun isMsaRequestWithNonAzureAuthority() { | ||
val nonAzureActiveDirectoryAuthority = AzureActiveDirectoryB2CAuthority("mockUrl") | ||
|
||
Assert.assertFalse(MsaUtil.isMsaRequest(nonAzureActiveDirectoryAuthority)) | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.