Skip to content

feat: Alias and Breakingchange through PSA #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 33 commits into
base: main
Choose a base branch
from

Conversation

Alex-Sol
Copy link
Contributor

@Alex-Sol Alex-Sol commented Sep 1, 2021

Description

  1. Alias
  2. Upcoming Breaking Change

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@Alex-Sol Alex-Sol marked this pull request as ready for review September 6, 2021 06:51
@isra-fel isra-fel self-assigned this Sep 6, 2021
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please write a markdown file about how to generate alias spec and breaking change spec. Put it in docs/

@Alex-Sol Alex-Sol requested a review from isra-fel September 10, 2021 07:14
@isra-fel isra-fel force-pushed the lizeng/PSACustomRules branch from a984b44 to 4b1eff3 Compare September 10, 2021 07:53
@isra-fel isra-fel force-pushed the lizeng/PSACustomRules branch from 4b1eff3 to 4b63e5c Compare September 10, 2021 07:58
@isra-fel
Copy link
Member

isra-fel commented Sep 23, 2021

Known issues:

  • PowerShellProcess.getSystemModulePath() does not get correct result -- C:\Users\yeliu\Documents\PowerShell\Modules is not in the result
    • root cause: it gets the module path of windows powershell
    • work-around: install via windows powershell with -Scope AllUsers
  • build.proj is packed into installer package
    • fix: add files that should not be packed into .vscodeignore

@YanaXu
Copy link
Contributor

YanaXu commented Aug 30, 2022

/azp where

2 similar comments
@YanaXu
Copy link
Contributor

YanaXu commented Aug 30, 2022

/azp where

@YanaXu
Copy link
Contributor

YanaXu commented Aug 30, 2022

/azp where

@azure-pipelines
Copy link

Azure DevOps orgs getting events for this repository:

@YanaXu
Copy link
Contributor

YanaXu commented Aug 30, 2022

/azp list

@azure-pipelines
Copy link

@YanaXu
Copy link
Contributor

YanaXu commented Aug 30, 2022

/azp run

@azure-pipelines
Copy link

Pull request contains merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants