Skip to content

chore: update bicep iac config #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 13, 2025
Merged

chore: update bicep iac config #41

merged 2 commits into from
May 13, 2025

Conversation

manekinekko
Copy link
Contributor

@manekinekko manekinekko commented May 13, 2025

No description provided.

@manekinekko manekinekko requested a review from Copilot May 13, 2025 15:14
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Bicep IaC configuration for the project, focusing on renaming services from “llama-index-nextjs” to “llama-index-javascript” and removing several shared module files.

  • Added a detailed next-steps documentation file outlining the process after running azd commands.
  • Removed obsolete/shared Bicep modules such as role, registry, monitoring, keyvault, cognitiveservices, apps-env, and the legacy llama-index-nextjs app.
  • Updated main Bicep and parameters files to reflect the new configuration and naming conventions.

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
next-steps.md Added documentation on post-init steps after azd init
infra/shared/*.bicep Removed several shared modules no longer required
infra/resources.bicep Introduced updated resource deployments using the new naming
infra/main.parameters.json Updated parameters to use "llama-index-javascript" naming
infra/main.bicep Refactored configuration to remove legacy modules and adjust outputs
infra/abbreviations.json Added a new abbreviation entry
azure.yaml Updated service name and template version for the JavaScript service
Comments suppressed due to low confidence (3)

infra/resources.bicep:63

  • [nitpick] Consider renaming the resource name to 'llamaIndexJavascriptIdentity' (with a capital 'I') for consistency in camel case usage.
  name: 'llamaIndexJavascriptidentity'

azure.yaml:5

  • [nitpick] Verify that the updated service name and template version correctly reflect the intended deployment configuration across your IaC.
    template: llama-index-javascript@1.15.1

infra/shared/role.bicep:1

  • Ensure the removal of this role module is intentional and that any dependencies on it have been updated in the deployment pipeline.
  -metadata description = 'Creates a role assignment for a service principal.'

principalId: principalId
llamaIndexJavascriptExists: llamaIndexJavascriptExists
Copy link
Preview

Copilot AI May 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider adding an inline comment explaining the purpose of the 'llamaIndexJavascriptExists' parameter for improved maintainability.

Copilot uses AI. Check for mistakes.

@manekinekko manekinekko merged commit 6b467bb into main May 13, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant