-
-
Notifications
You must be signed in to change notification settings - Fork 156
fix(deps): upgrade packaging #2557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -94,7 +94,7 @@ | |||
"cchecksum>=0.0.3,<1", | |||
# Pandas peer-dep: Numpy 2.0 causes issues for some users. | |||
"numpy<2", | |||
"packaging>=23.0,<24", | |||
"packaging>=24.2,<25", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have to fix in some downstream plugins before this will succeed: https://github.com/ApeWorX/ape-hardhat/blob/main/setup.py#L81
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually... This is a bit of a circular dependency. The container depends on both core Ape and plugins. Plugins depend on core ape. This why I think recommened_plugins
type flows don't make much sense.
The only solution to merge with with a failing solution and then update the plugin and then the next update of core ape will have it all fixed.
@fubuloubu can we merge this? ill fix the plugins |
Yes, sounds more complex than I expected, thank you for taking this up! |
This pull request is considered stale because it has been open 30 days with no activity. Remove stale label, add a comment, or make a new commit, otherwise this PR will be closed in 5 days. |
This PR was closed because it has been inactive for 35 days. |
What I did
I guess
setuptools
upgraded there pin and it screwed us:https://github.com/ApeWorX/ape/actions/runs/13958350355/job/39075553268
How I did it
How to verify it
Checklist