refactor: add option converter

Author: yeonjuan

.babelrc

@@ -10,5 +10,6 @@
     ],
     "@babel/preset-typescript",
     "@babel/preset-react"
-  ]
+  ],
+  "ignore": ["**/__tests__"]
 }

jest.config.js

@@ -0,0 +1,7 @@
+module.exports = {
+  preset: "ts-jest",
+  testEnvironment: "node",
+  moduleNameMapper: {
+    "@/(.*)$": "<rootDir>/src/$1",
+  },
+};

package.json

@@ -17,7 +17,9 @@
     "gen:libs": "ts-node scripts/gen-libs.ts",
     "clear": "ts-node scripts/rm-rf.ts ./dist ",
     "//deploy": "deploy",
-    "deploy": "npm run build && gh-pages -d dist"
+    "deploy": "npm run build && gh-pages -d dist",
+    "//test": "test",
+    "test": "jest"
   },
   "repository": {
     "type": "git",
@@ -50,6 +52,7 @@
     "@babel/preset-typescript": "^7.10.4",
     "@types/codemirror": "0.0.98",
     "@types/eslint": "^7.2.4",
+    "@types/jest": "^26.0.14",
     "@types/react": "^16.9.51",
     "@types/react-bootstrap": "^0.32.24",
     "@types/react-dom": "^16.9.8",
@@ -63,6 +66,7 @@
     "gh-pages": "^3.1.0",
     "html-loader": "^1.3.1",
     "html-webpack-plugin": "^4.5.0",
+    "jest": "^26.5.3",
     "json-loader": "^0.5.7",
     "lodash": "^4.17.20",
     "null-loader": "^4.0.0",
@@ -71,6 +75,7 @@
     "react-app-rewired": "^2.1.6",
     "style-loader": "^1.3.0",
     "terser-webpack-plugin": "^4.2.3",
+    "ts-jest": "^26.4.1",
     "ts-node": "^9.0.0",
     "webpack": "^4.44.2",
     "webpack-bundle-analyzer": "^3.9.0",

src/lib/__tests__/parser-options-converter.test.ts

@@ -0,0 +1,27 @@
+import * as converter from "@/lib/parser-options-converter";
+import { ParserOptions } from "@typescript-eslint/parser";
+import { JsxEmit } from "typescript";
+
+const JSX_PARSER_OPTIONS: ParserOptions = {
+  ecmaVersion: 2019,
+  ecmaFeatures: {
+    jsx: true,
+    globalReturn: true,
+  },
+  sourceType: "module",
+};
+
+describe("parser-options-converter", () => {
+  it("toTSESTOptions", () => {
+    expect(converter.toTSESTOptions(JSX_PARSER_OPTIONS)).toMatchObject({
+      jsx: true,
+      useJSXTextNode: true,
+    });
+  });
+
+  it("toCompilerOptions", () => {
+    expect(converter.toCompilerOptions(JSX_PARSER_OPTIONS)).toMatchObject({
+      jsx: JsxEmit.Preserve,
+    });
+  });
+});

src/lib/create-ast-program.ts

@@ -9,32 +9,32 @@ import type { SourceFile, Program } from "typescript";
 import { createCompilerHost } from "./compiler-host";
 import { createFilesIncludeLibs } from "./files";
 import { createSourceFilesIncludeLibs } from "./source-files";
+import { toCompilerOptions } from "@/lib/parser-options-converter";
 import { DEMO_FILE_NAME } from "@/constants";
+import type { ParserOptions } from "@typescript-eslint/types";
 
 interface ASTandProgram {
   ast?: SourceFile;
   program: Program;
 }
 
-export function createAstAndProgram(code: string, extra: any): ASTandProgram {
+export function createAstAndProgram(
+  code: string,
+  parserOptions: ParserOptions
+): ASTandProgram {
   const files = createFilesIncludeLibs(DEMO_FILE_NAME, code);
   const sourceFiles = createSourceFilesIncludeLibs(
     DEMO_FILE_NAME,
     code,
-    extra.jsx ? ScriptKind.TSX : ScriptKind.TS
+    parserOptions?.ecmaFeatures?.jsx ? ScriptKind.TSX : ScriptKind.TS
   );
 
   const compilierHost = createCompilerHost(files, sourceFiles);
-
+  const compilerOptions = toCompilerOptions(parserOptions);
+  compilerOptions.jsx;
   const program = createProgram(
     Object.keys(files),
-    {
-      noResolve: true,
-      strict: true,
-      target: ScriptTarget.Latest,
-      jsx: extra.jsx ? JsxEmit.Preserve : undefined,
-      module: ModuleKind.ES2015,
-    },
+    compilerOptions,
     compilierHost
   );
   const ast = program.getSourceFile(DEMO_FILE_NAME);

src/lib/parser-options-converter.ts

@@ -0,0 +1,32 @@
+import type { ParserOptions } from "@typescript-eslint/types";
+import type { AnalyzeOptions } from "@typescript-eslint/scope-manager";
+import type { TSESTreeOptions } from "@typescript-eslint/typescript-estree";
+import { CompilerOptions, ScriptTarget, JsxEmit, ModuleKind } from "typescript";
+
+export function toAnalyzeOptions(parserOptions: ParserOptions): AnalyzeOptions {
+  return {
+    ecmaVersion: parserOptions.ecmaVersion,
+    globalReturn: parserOptions.ecmaFeatures?.globalReturn ?? false,
+    sourceType: parserOptions.sourceType ?? "script",
+  };
+}
+
+export function toTSESTOptions(parserOptions: ParserOptions): TSESTreeOptions {
+  return Object.assign({}, parserOptions, {
+    jsx: parserOptions.ecmaFeatures?.jsx ?? false,
+    useJSXTextNode: true,
+    projectFolderIgnoreList: [],
+  });
+}
+
+export function toCompilerOptions(
+  parserOptions: ParserOptions
+): CompilerOptions {
+  return {
+    noResolve: true,
+    strict: true,
+    target: ScriptTarget.Latest,
+    jsx: parserOptions.ecmaFeatures?.jsx ? JsxEmit.Preserve : undefined,
+    module: ModuleKind.ES2015,
+  };
+}

src/lib/parser.ts

@@ -2,6 +2,10 @@ import { analyze } from "@typescript-eslint/scope-manager";
 import { visitorKeys } from "@typescript-eslint/typescript-estree";
 import { astConverter } from "../../node_modules/@typescript-eslint/typescript-estree/dist/ast-converter";
 import { createAstAndProgram } from "@/lib/create-ast-program";
+import {
+  toAnalyzeOptions,
+  toTSESTOptions,
+} from "@/lib/parser-options-converter";
 import type { ParserOptions, TSESTree } from "@typescript-eslint/types";
 import type {
   ParserServices,
@@ -54,7 +58,7 @@ function parseAndGenerateServices<T extends TSESTreeOptions = TSESTreeOptions>(
   extra.code = code;
   extra.jsx = options.jsx;
 
-  const { ast, program } = createAstAndProgram(code, extra);
+  const { ast, program } = createAstAndProgram(code, options);
   const { estree, astMaps } = astConverter(ast!, extra, true);
   return {
     ast: estree as AST<T>,
@@ -71,19 +75,9 @@ export function parseForESLint(
   code: string,
   parserOptions: ParserOptions
 ): ParseForESLintResult {
-  const TSESOptions: TSESTreeOptions = Object.assign(parserOptions, {
-    jsx: parserOptions.ecmaFeatures?.jsx || false,
-    useJSXTextNode: true,
-  });
-
-  const { ast, services } = parseAndGenerateServices(code, TSESOptions);
-
-  const analyzeOptions = {
-    ecmaVersion: parserOptions.ecmaVersion,
-    globalReturn: parserOptions.ecmaFeatures?.globalReturn,
-    sourceType: parserOptions.sourceType,
-  };
-
+  const tsesOptions = toTSESTOptions(parserOptions);
+  const { ast, services } = parseAndGenerateServices(code, tsesOptions);
+  const analyzeOptions = toAnalyzeOptions(parserOptions);
   const scopeManager = analyze(ast, analyzeOptions);
   return { ast, services, scopeManager, visitorKeys };
 }