Skip to content

Audit usage of Debug {:?} formatting #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wwylele opened this issue Dec 28, 2022 · 0 comments
Open

Audit usage of Debug {:?} formatting #35

wwylele opened this issue Dec 28, 2022 · 0 comments

Comments

@wwylele
Copy link
Owner

wwylele commented Dec 28, 2022

{:?} in principle should be only used for dev purpose and not in product output. For this project, it should be used in the following situation

  • printing to stderr is fine
  • output to website when a record (monster, item etc.) is not found for a given ID is ok
  • output yet to understand property to website is temporarily ok, but should be continue investigated
  • output already understood enum to website shouldn't go through Debug any more
  • shouldn't be part of any url
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wwylele