You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I use the robin map in my project as a submodule and set the variable NB_USE_SUBMODULE_DEPS to false. However the check for this submodule uses CMakeFindDependencyMacro which does find it. I think it would be better to omit this check completely and just link to tsl::robin_map when NB_USE_SUBMODULE_DEPS is true so the user of nanobind can decide to use the submodule.
Another approach which I use sometimes is to check if the target is already defined and do not include any subdirectory when this is the case.
The text was updated successfully, but these errors were encountered:
Uh oh!
There was an error while loading. Please reload this page.
I use the robin map in my project as a submodule and set the variable NB_USE_SUBMODULE_DEPS to false. However the check for this submodule uses CMakeFindDependencyMacro which does find it. I think it would be better to omit this check completely and just link to tsl::robin_map when NB_USE_SUBMODULE_DEPS is true so the user of nanobind can decide to use the submodule.
Another approach which I use sometimes is to check if the target is already defined and do not include any subdirectory when this is the case.
The text was updated successfully, but these errors were encountered: