Skip to content

[OTHER]: Check if robin_map is already included #967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GMellar opened this issue Mar 12, 2025 · 1 comment
Open

[OTHER]: Check if robin_map is already included #967

GMellar opened this issue Mar 12, 2025 · 1 comment

Comments

@GMellar
Copy link

GMellar commented Mar 12, 2025

I use the robin map in my project as a submodule and set the variable NB_USE_SUBMODULE_DEPS to false. However the check for this submodule uses CMakeFindDependencyMacro which does find it. I think it would be better to omit this check completely and just link to tsl::robin_map when NB_USE_SUBMODULE_DEPS is true so the user of nanobind can decide to use the submodule.

Another approach which I use sometimes is to check if the target is already defined and do not include any subdirectory when this is the case.

@wjakob
Copy link
Owner

wjakob commented Apr 8, 2025

I don't quite understand the issue. Are you not saying that CMakeFindDependencyMacro finds the right dependency? Or did I misunderstand?

If a change of this part of the CMake logic is needed, could I ask you to make a concrete proposal by opening a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants