Enable dupword, unconvert linters (#1658)

Author: alexandear

.golangci.yml

@@ -11,7 +11,6 @@ linters:
     - cyclop
     - depguard
     - dupl
-    - dupword
     - errname
     - errorlint
     - exhaustive
@@ -43,7 +42,6 @@ linters:
     - testpackage
     - thelper
     - tparallel
-    - unconvert
     - unparam
     - usestdlibvars
     - varnamelen

bytesconv_test.go

@@ -37,7 +37,7 @@ func TestAppendHTMLEscape(t *testing.T) {
 		allcases[i] = byte(i)
 	}
 	res := string(AppendHTMLEscape(nil, string(allcases)))
-	expect := string(html.EscapeString(string(allcases)))
+	expect := html.EscapeString(string(allcases))
 	if res != expect {
 		t.Fatalf("unexpected string %q. Expecting %q.", res, expect)
 	}

client.go

@@ -1474,6 +1474,7 @@ func (c *HostClient) acquireConn(reqTimeout time.Duration, connectionClose bool)
 			return nil, ErrNoFreeConns
 		}
 
+		//nolint:dupword
 		// reqTimeout    c.MaxConnWaitTimeout   wait duration
 		//     d1                 d2            min(d1, d2)
 		//  0(not set)            d2            d2

fs.go

@@ -870,7 +870,7 @@ func (cm *inMemoryCacheManager) GetFileFromCache(cacheKind CacheKind, path strin
 	fileCache := cm.getFsCache(cacheKind)
 
 	cm.cacheLock.Lock()
-	ff, ok := fileCache[string(path)]
+	ff, ok := fileCache[path]
 	if ok {
 		ff.readersCount++
 	}
@@ -1594,7 +1594,7 @@ func (h *fsHandler) newFSFile(f fs.File, fileInfo fs.FileInfo, compressed bool,
 }
 
 func readFileHeader(f io.Reader, compressed bool, fileEncoding string) ([]byte, error) {
-	r := io.Reader(f)
+	r := f
 	var (
 		br *brotli.Reader
 		zr *gzip.Reader

http_test.go

@@ -3022,7 +3022,7 @@ func TestResponseBodyStream(t *testing.T) {
 			}
 		})
 
-		t.Run("limit response body size size", func(t *testing.T) {
+		t.Run("limit response body size", func(t *testing.T) {
 			t.Parallel()
 
 			client := Client{StreamResponseBody: true, MaxResponseBodySize: 20}