Skip to content

Exiting a filter creation/update from the table column header with escape doesn't remove the editable filter chip #12319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lucasbordeau opened this issue May 27, 2025 · 4 comments

Comments

@lucasbordeau
Copy link
Contributor

It should be removed, like when we click outside.

Enregistrement.de.l.ecran.2025-05-27.a.12.34.29.mov
@AjayAdsule
Copy link
Contributor

Hey @FelixMalfait i am working on this issue when I first time select filter and press escape button selected filters are gone it's default behaviour if you want video please tell i will add as reference

@AjayAdsule
Copy link
Contributor

AjayAdsule commented May 28, 2025

can you confirm me is this default behaviour, if i press esc on first time the filter should not to be save

Screen.Recording.2025-05-28.at.9.59.13.PM.mov

@Bonapara
Copy link
Member

I think we should persist the filter value and close the modal (as seems to be the case today). @lucasbordeau, maybe I missed your point?

The issue I notice with this filter is that the values from the picker get reordered and flash when selected:

CleanShot.2025-05-30.at.11.02.13.mp4

@lucasbordeau
Copy link
Contributor Author

lucasbordeau commented Jun 3, 2025

@AjayAdsule No this is not the expected behavior, it should be remove only if the filter value is considered empty, in your example it is not empty.

It is not a matter of first of next times, it is only if it is empty or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🔖 Planned
Development

No branches or pull requests

3 participants