Skip to content

Promise subclassing should throw errors. #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
aapoalas opened this issue May 21, 2025 · 0 comments
Open

Promise subclassing should throw errors. #710

aapoalas opened this issue May 21, 2025 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@aapoalas
Copy link
Member

aapoalas commented May 21, 2025 •
edited
Loading

We panic at nova_vm/src/ecmascript/builtins/control_abstraction_objects/promise_objects/promise_constructor.rs:126:9:, nova_vm/src/ecmascript/builtins/control_abstraction_objects/promise_objects/promise_constructor.rs:247:9:, 279, 313, and 370 on assertions; we should change these to throw errors instead.
@aapoalas aapoalas added bug Something isn't working good first issue Good for newcomers labels May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aapoalas