fix(BitMatrix): fix bug where getting indexes by column results in RangeError

Fixes #2

Author: sularome

tests/BitMatrixSpec.ts

@@ -293,4 +293,22 @@ describe("BitMatrix", function () {
         expect(bs.getRowIndexes(31)).toEqual([6, 31]);
         expect(bs.getRowIndexes(32)).toEqual([6, 32]);
     });
+    it("be able to get set bits per column when column count < row count", function () {
+        const bm = new BitMatrix(100, 10);
+        bm.set(2, 1, true);
+        bm.set(3, 9, true);
+        expect(bm.getIndexes(true)[0]).toEqual([]);
+        expect(bm.getIndexes(true)[1]).toEqual([2]);
+        expect(bm.getIndexes(true)[9]).toEqual([3]);
+        bm.set(4, 8, true);
+        expect(bm.getIndexes(true)[0]).toEqual([]);
+        expect(bm.getIndexes(true)[1]).toEqual([2]);
+        expect(bm.getIndexes(true)[8]).toEqual([4]);
+        expect(bm.getIndexes(true)[9]).toEqual([3]);
+        bm.set(4, 8, false);
+        expect(bm.getIndexes(true)[0]).toEqual([]);
+        expect(bm.getIndexes(true)[1]).toEqual([2]);
+        expect(bm.getIndexes(true)[8]).toEqual([]);
+        expect(bm.getIndexes(true)[9]).toEqual([3]);
+    });
 });

ts/BitMatrix.ts

@@ -54,7 +54,7 @@ export class BitMatrix implements IBitMatrix {
         let result: number[][] = [];
         let index: number = 0;
         if (resultPerColumn) {
-            while (index < this.rowCount) {
+            while (index < this.colCount) {
                 result.push(this.getColIndexes(index));
                 index++;
             }
@@ -180,11 +180,11 @@ export class BitMatrix implements IBitMatrix {
     }
 
     private validateIndex(rowIndex: number, colIndex: number) {
-        if (rowIndex > this.rowCount - 1 || rowIndex < 0) {
-            throw new RangeError("Row index is incorrect.");
+        if (rowIndex >= this.rowCount || rowIndex < 0) {
+            throw new RangeError(`Row index is incorrect. Maximum allowed index: ${this.rowCount - 1}. Actual index ${rowIndex}`);
         }
-        if (colIndex > this.colCount - 1 || colIndex < 0) {
-            throw new RangeError("Column index is incorrect.");
+        if (colIndex >= this.colCount || colIndex < 0) {
+            throw new RangeError(`Column index is incorrect. Maximum allowed index: ${this.colCount - 1}. Actual index ${colIndex}`);
         }
     }
 }