Skip to content

[P1] Are make_last_position_supervised_chat_data_module and make_last_position_supervised_data_module the same? #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #158
weissercn opened this issue Feb 6, 2025 · 3 comments

Comments

@weissercn
Copy link

https://github.com/stanfordnlp/pyreft/blob/f51f4e5c92ddfab234c70d038b8e0c0231ce995e/pyreft/dataset.py#L492C5-L492C51

They seem to be the same other than their name.

@frankaging
Copy link
Collaborator

@weissercn Thanks for catching this, yes, it seems like they are the same. We will mark this as resolved but will do some refacotory work later.

@frankaging frankaging changed the title Are make_last_position_supervised_chat_data_module and make_last_position_supervised_data_module the same? [P1] Are make_last_position_supervised_chat_data_module and make_last_position_supervised_data_module the same? Feb 6, 2025
@frankaging frankaging mentioned this issue Feb 6, 2025
1 task
@frankaging
Copy link
Collaborator

tracking here: #158

@weissercn
Copy link
Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants