remove Report method

Author: dmelikyan

README.md

@@ -20,7 +20,7 @@ Learn more on the [features](https://stackimpact.com/features/) page (with scree
 
 #### How it works
 
-The StackImpact profiler agent is imported into a program and used as a normal package. When the program runs, various sampling profilers are started and stopped automatically by the agent and/or programmatically using the agent methods. The agent periodically reports recorded profiles and metrics to the StackImpact Dashboard. If an application has multiple processes, also referred to as workers, instances or nodes, only one process will have an active agent at any point of time. The agent can also operate in manual mode, which should be used in development only.
+The StackImpact profiler agent is imported into a program and used as a normal package. When the program runs, various sampling profilers are started and stopped automatically by the agent and/or programmatically using the agent methods. The agent periodically reports recorded profiles and metrics to the StackImpact Dashboard. The agent can also operate in manual mode, which should be used in development only.
 
 
 #### Documentation
@@ -218,4 +218,4 @@ To enable debug logging, add `Debug: true` to startup options. If the debug log
 
 ## Overhead
 
-The agent overhead is measured to be less than 1% for applications under high load. For applications that are horizontally scaled to multiple processes, StackImpact agents are only active on a small subset of the processes at any point of time, therefore the total overhead is much lower.
+The agent overhead is measured to be less than 1% for applications under high load.

agent.go

@@ -4,7 +4,6 @@ import (
 	"fmt"
 	"log"
 	"net/http"
-	"sync/atomic"
 
 	"github.com/stackimpact/stackimpact-go/internal"
 )
@@ -31,8 +30,7 @@ type Options struct {
 type Agent struct {
 	internalAgent *internal.Agent
 
-	spanStarted   int32
-	reportStarted int32
+	spanStarted int32
 
 	// compatibility < 1.2.0
 	DashboardAddress string
@@ -47,7 +45,6 @@ func NewAgent() *Agent {
 	a := &Agent{
 		internalAgent: internal.NewAgent(),
 		spanStarted:   0,
-		reportStarted: 0,
 	}
 
 	return a
@@ -284,24 +281,10 @@ func (a *Agent) RecordAndRecoverPanic() {
 	}
 }
 
-// Reports profiles to the Dashboard in manual or focused profiling mode.
-// Only reports once every few minutes and only if the agent is active.
+// DEPRECATED. Kept for compatibility.
 func (a *Agent) Report() {
-	a.ReportWithHTTPClient(nil)
 }
 
-// Same as Report, but uses given http.Client.
+// DEPRECATED. Kept for compatibility.
 func (a *Agent) ReportWithHTTPClient(client *http.Client) {
-	if !atomic.CompareAndSwapInt32(&a.reportStarted, 0, 1) {
-		return
-	}
-	defer func() {
-		atomic.StoreInt32(&a.reportStarted, 0)
-	}()
-
-	if client != nil {
-		a.internalAgent.HTTPClient = client
-	}
-
-	a.internalAgent.Report()
 }

examples/aws-lambda/main.go

@@ -18,9 +18,6 @@ func Handler(request events.APIGatewayProxyRequest) (events.APIGatewayProxyRespo
 	span := agent.Profile()
 	defer span.Stop()
 
-	// periodically send profiles to the sashboard (not on every request)
-	defer agent.Report()
-
 	// simulate cpu work
 	for i := 0; i < 1000000; i++ {
 		rand.Intn(1000)

internal/agent.go

@@ -16,7 +16,7 @@ import (
 	"time"
 )
 
-const AgentVersion = "2.3.9"
+const AgentVersion = "2.3.10"
 const SAASDashboardAddress = "https://agent-api.stackimpact.com"
 
 var agentPath = filepath.Join("github.com", "stackimpact", "stackimpact-go")
@@ -305,13 +305,11 @@ func (a *Agent) Report() {
 
 	a.configLoader.load()
 
-	if !a.AutoProfiling {
-		a.cpuReporter.report(true)
-		a.allocationReporter.report(true)
-		a.blockReporter.report(true)
+	a.cpuReporter.report(true)
+	a.allocationReporter.report(true)
+	a.blockReporter.report(true)
 
-		a.messageQueue.flush(true)
-	}
+	a.messageQueue.flush(true)
 }
 
 func (a *Agent) log(format string, values ...interface{}) {

span.go

@@ -42,6 +42,11 @@ func (s *Span) Stop() {
 		if s.active {
 			s.agent.internalAgent.StopProfiling()
 		}
+
+		if !s.agent.internalAgent.AutoProfiling {
+			s.agent.internalAgent.Report()
+		}
+
 		atomic.StoreInt32(&s.agent.spanStarted, 0)
 	}
 }